Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HttpKernel] Fix message for unresovable arguments of invokable controllers #48273

Merged
merged 1 commit into from Nov 22, 2022
Merged

[HttpKernel] Fix message for unresovable arguments of invokable controllers #48273

merged 1 commit into from Nov 22, 2022

Conversation

fancyweb
Copy link
Contributor

@fancyweb fancyweb commented Nov 21, 2022

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Before:

Could not resolve argument $logger of "app\controller\foocontroller()", maybe you ...

After:

Could not resolve argument $logger of "App\Controller\FooController::__invoke()", maybe you ...

@carsonbot carsonbot added this to the 4.4 milestone Nov 21, 2022
fabpot
fabpot approved these changes Nov 22, 2022
View changes
@fabpot
Copy link
Member

fabpot commented Nov 22, 2022

Thank you @fancyweb.

@fabpot fabpot merged commit 51cdc3a into symfony:4.4 Nov 22, 2022
10 checks passed
@fancyweb fancyweb deleted the http-kernel/fix-not-tagged-invokable-controller branch Nov 22, 2022
This was referenced Nov 25, 2022
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot

Assignees
No one assigned
Labels
Bug HttpKernel Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fancyweb @fabpot @carsonbot