MAINT Parameters validation for sklearn.metrics.mean_absolute_error
#24943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glemaitre
reviewed
Nov 15, 2022
|
You will be able to remove the linting error by merging |
glemaitre
reviewed
Nov 15, 2022
thomasjpfan
approved these changes
Nov 25, 2022
|
@mknz There is a merge conflict with this PR. May you sync with If you are having issues, you can check "Allow edits by maintainers" in the right side panel in the GitHub UI in this PR. This allows a maintainer to fix the merge conflict for you. |
|
Thanks for reviewing and comments! @jeremiedbb @thomasjpfan @jeremiedbb |
jjerphan
pushed a commit
to jjerphan/scikit-learn
that referenced
this pull request
Jan 20, 2023
jjerphan
pushed a commit
to jjerphan/scikit-learn
that referenced
this pull request
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Towards #24862
What does this implement/fix? Explain your changes.
Added
validate_paramsdecorator tosklearn.metrics.mean_absolute_error.Any other comments?
There are already validation codes in this function. Since they are checking the contents of input data, I left the part as it is.