Skip to content

Playwright: Added possibility of creating of a context with a page #3398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 29, 2022
Merged

Playwright: Added possibility of creating of a context with a page #3398

merged 6 commits into from
Nov 29, 2022

Conversation

mirao
Copy link
Contributor

@mirao mirao commented Aug 26, 2022

Motivation/Description of the PR

Applicable helpers:

  • WebDriver
  • Puppeteer
  • Nightmare
  • REST
  • FileHelper
  • Appium
  • Protractor
  • TestCafe
  • Playwright

Applicable plugins:

  • allure
  • autoDelay
  • autoLogin
  • customLocator
  • pauseOnFail
  • coverage
  • retryFailedStep
  • screenshotOnFail
  • selenoid
  • stepByStepReport
  • stepTimeout
  • wdio
  • subtitles

Type of change

  • 🔥 Breaking changes
  • 🚀 New functionality
  • 🐛 Bug fix
  • 📋 Documentation changes/updates
  • ♨️ Hot fix
  • 🔨 Markdown files fix - not related to source code
  • 💅 Polish code

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

@Arhell Arhell requested a review from DavertMik August 27, 2022 06:45
@DavertMik
Copy link
Contributor

Thanks, seems useful
Could you add also usage documentation into https://github.com/codeceptjs/CodeceptJS/blob/3.x/docs/playwright.md

It would be also nice to have a more detailed example where you actually use _startBrowser and _startContextPage

This will help others to start using these custom methods

@mirao
Copy link
Contributor Author

mirao commented Aug 31, 2022

Added an example into Playwright's docs, it's my use case for _createContextPage

@DavertMik
Copy link
Contributor

@mirao what do you think of adding restartBrowser into the Playwright helper?

Looks like it should belong there

@mirao
Copy link
Contributor Author

mirao commented Sep 13, 2022

@DavertMik Yes, I can add the method restartBrowser() into the Playwright's helper. Or should I name it _restartBrowser()? I'm not sure about name convention.

@DavertMik
Copy link
Contributor

restartBrowser()

So user could call it natively from their tests, please update documentation accordingly to show simplified approach

@mirao
Copy link
Contributor Author

mirao commented Sep 14, 2022

@DavertMik Done

@DavertMik
Copy link
Contributor

Thank you!
Finally we have it!

@DavertMik DavertMik merged commit 9983586 into codeceptjs:3.x Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavertMik DavertMik DavertMik approved these changes

@Arhell Arhell Arhell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Playwright: Method _startBrowser() doesn't start browser window since CodeceptJS 3.1.0
3 participants
@mirao @DavertMik @Arhell