Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker fix #981

Merged
merged 25 commits into from Mar 6, 2018
Merged

Docker fix #981

merged 25 commits into from Mar 6, 2018

Conversation

DavertMik
Copy link
Contributor

@DavertMik DavertMik commented Mar 2, 2018

I stumbled upon some issues using Docker image. It was broken when all the project files were moved from root directory to /codecept. This PR fixes it simplifies usage of image.

Conventions

  • this directory will be added as /codecept insde container
  • tests directory is expected to be mounted as /tests
  • codeceptjs is a synlink to /codecept/bin/codecept.js

Local usage (for Puppeteer and Nightmare)

docker run --net=host -v $PWD:/tests codeception/codeceptjs

To customize execution call codeceptjs command:

# run tests with steps
docker run --net=host -v $PWD:/tests codeception/codeceptjs codeceptjs run --steps

# run tests with @user in a name
docker run --net=host -v $PWD:/tests codeception/codeceptjs codeceptjs run --grep "@user"

I didn't test this for Puppeteer and Nightmare. We need to setup CircleCI to test the docker image and run some of our tests

@DavertMik
Copy link
Contributor Author

@DavertMik DavertMik commented Mar 3, 2018

This PR should also implement fixes for CircleCI

@codeceptjs codeceptjs deleted a comment Mar 5, 2018
@codeceptjs codeceptjs deleted a comment Mar 5, 2018
@codeceptjs codeceptjs deleted a comment Mar 5, 2018
@codeceptjs codeceptjs deleted a comment Mar 5, 2018
@codeceptjs codeceptjs deleted a comment Mar 5, 2018
@codeceptjs codeceptjs deleted a comment Mar 5, 2018
@codeceptjs codeceptjs deleted a comment Mar 5, 2018
@codeceptjs codeceptjs deleted a comment Mar 5, 2018
@codeceptjs codeceptjs deleted a comment Mar 5, 2018
@codeceptjs codeceptjs deleted a comment Mar 5, 2018
@codeceptjs codeceptjs deleted a comment Mar 5, 2018
@codeceptjs codeceptjs deleted a comment Mar 5, 2018
@codeceptjs codeceptjs deleted a comment Mar 5, 2018
@codeceptjs codeceptjs deleted a comment Mar 5, 2018
@codeceptjs codeceptjs deleted a comment Mar 5, 2018
@codeceptjs codeceptjs deleted a comment Mar 5, 2018
@codeceptjs codeceptjs deleted a comment Mar 5, 2018
@codeceptjs codeceptjs deleted a comment Mar 5, 2018
@codeceptjs codeceptjs deleted a comment Mar 5, 2018
@DavertMik
Copy link
Contributor Author

@DavertMik DavertMik commented Mar 6, 2018

Tests on Circle CI are passing. Even for Puppeteer and Nightmare!

@codeceptjs codeceptjs deleted a comment Mar 6, 2018
@DavertMik DavertMik merged commit 8f71798 into master Mar 6, 2018
3 of 6 checks passed
@DavertMik DavertMik deleted the docker-fix branch Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant