codeceptjs / CodeceptJS Public
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker fix #981
Merged
Merged
Docker fix #981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR should also implement fixes for CircleCI |
Tests on Circle CI are passing. Even for Puppeteer and Nightmare! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
I stumbled upon some issues using Docker image. It was broken when all the project files were moved from root directory to
/codecept
. This PR fixes it simplifies usage of image.Conventions
/codecept
insde container/tests
codeceptjs
is a synlink to/codecept/bin/codecept.js
Local usage (for Puppeteer and Nightmare)
To customize execution call
codeceptjs
command:I didn't test this for Puppeteer and Nightmare. We need to setup CircleCI to test the docker image and run some of our tests