feat: rewrite the ObservableArray #9067
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is now an ArrayLike object. Meaning we can do `test[4]= 4;` and the array will be changed as well as a change event trigger. It should work exactly as the current implementation. One nice feature i would have liked which does not work yet is ` test instanceof Array`. If that was to work it means an `ObservableArray` could be used anywhere and even passed to native methods (i think)
|
I found some issues with the WeakMap and that new implementation. That PR is not ready yet |
NathanWalker
force-pushed
the
release/8.0.0
branch
from
b286d51 to
a2896c9
Compare
|
@farfromrefug If this were ready soon we could likely include in 8.6, would just need to check any breaking changes to mention if so. Otherwise can target 9.0. |
|
@NathanWalker that one is really old. I will check if I use it in my fork. Doesn't Dimitris created one doing a better job? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is now an ArrayLike object. Meaning we can do
test[4]= 4;and the array will be changed as well as a change event trigger.It should work exactly as the current implementation.
One nice feature i would have liked which does not work yet is
test instanceof Array.If that was to work it means an
ObservableArraycould be used anywhere and even passed to native methods (i think)Forgot to say why i started this. This PR also brings all array like methods to
ObservableArraylikefindIndex