Skip to content

feat(webpack): default tsconfig.json if not found #9784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

rigor789
Copy link
Member

Open for discussion if this is something we want to support. The alternative is #9715 where we disable ts support altogether in non-ts projects.

If we opt to use #9715 instead, it needs a few adjustments to remove .ts files from the resolve rules etc.

PR Checklist

What is the current behavior?

Using .ts file in non-ts projects throw errors (as expected at the moment)

What is the new behavior?

If the project does not have a tsconfig.json a default one is used from @nativescript/webpack. The user is still required to install typescript to use ts files.

fixes #9715

@cla-bot cla-bot bot added the cla: yes label Feb 18, 2022
@rigor789
Copy link
Member Author

@dimitrisrk I'm curious about your thoughts on this approach.

@CatchABus
Copy link
Contributor

@dimitrisrk I'm curious about your thoughts on this approach.

My main issue was tsconfig file missing, so I guess this settles it too. No objections from my side!

@rigor789 rigor789 marked this pull request as draft March 3, 2022 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants