Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tk savefig formats #24531

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

daniilS
Copy link
Contributor

@daniilS daniilS commented Nov 21, 2022

PR Summary

This also allows us to sort all extensions in alphabetical order, in line with the other backends, rather than having to put the default option first.

This change required raising the minimum supported version of Tk to 8.5, as discussed in #24450. I also removed a try statement around iconphoto, which should only have failed on Tk < 8.5 - it didn't feel big enough to deserve its own PR, but happy to separate it out if anyone disagrees.

Closes #24450.

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • [N/A] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • [N/A] New plotting related features are documented with examples.

Release Notes

  • [N/A] New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MNT]: Fix or drop support for Tk 8.4
1 participant