Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: typo (Indention) #99904

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

jarrodcolburn
Copy link

@jarrodcolburn jarrodcolburn commented Nov 30, 2022

Example needed to be indented. Was trying to call a context manger pr (from with cProfile.Profile() as pr:) wot perform pr.print_stats() once it had already exited.

Example needed to be indented. Was trying to call a context manger `pr` (from ` with cProfile.Profile() as pr:`) wot perform ` pr.print_stats()` once it had already exited.
@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Nov 30, 2022
@cpython-cla-bot
Copy link

cpython-cla-bot bot commented Nov 30, 2022

All commit authors signed the Contributor License Agreement.
CLA signed

Copy link
Member

@AlexWaygood AlexWaygood left a comment

Looks good, but we need one more space of indentation. Also, please sign the CLA, or we won't be able to merge this, unfortunately :)

@@ -274,7 +274,7 @@ functions:
with cProfile.Profile() as pr:
# ... do something ...

pr.print_stats()
pr.print_stats()
Copy link
Member

@AlexWaygood AlexWaygood Nov 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pr.print_stats()
pr.print_stats()

@bedevere-bot
Copy link

bedevere-bot commented Nov 30, 2022

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants