Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#15262: Round calculated max before compare with max from options. #1940

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

#15262: Round calculated max before compare with max from options. #1940

wants to merge 9 commits into from

Conversation

@tkiseleva
Copy link

@tkiseleva tkiseleva commented Dec 14, 2020

Fix for https://bugs.jqueryui.com/ticket/15262
tkiseleva added 5 commits Dec 14, 2020
@tkiseleva
#15262: Round calculated max before compare with max from options.
88f7feb
@tkiseleva
#15262: Correct codestyle.
3304b54
@tkiseleva
#15262: Correct logic to cover failed test.
0f3a8fa
@tkiseleva
#15262: Correct codestyle.
587371f
@tkiseleva
#15262: Correct codestyle.
aa710e9
@tkiseleva
Copy link
Author

@tkiseleva tkiseleva commented Dec 14, 2020

I'm not sure that the failed test is the correct one.
The initial issue happens when in the setting I've set 8.003, but in js, it received as 8.0029999...

Or maybe provide some additional option if the max value should be covered or not.

tkiseleva added 4 commits Dec 18, 2020
@tkiseleva
#15262: Add option which allow to define if max should be covered or …
6c2c424 
…not.
@tkiseleva
#15262: Correct codestyle.
03ccd34
@tkiseleva
#15262: Correct logic for cover tests.
204fcb1
@tkiseleva
#15262: Correct logic for cover tests.
c234a2b
@tkiseleva
Copy link
Author

@tkiseleva tkiseleva commented Dec 18, 2020

I've returned main part as it was before, but added new options includeMax, if it's true, it will increase the max if it's not covered by range.
But tests are failed, I couldn't find how to fix, it something related to default options.

Base automatically changed from master to main Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Comp: Slider
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@tkiseleva @fnagel