net: rework the unified CNAME handling on unix #57093
Conversation
|
This PR (HEAD: d53187d) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/455275 to see it. Tip: You can toggle comments from me using the |
|
This PR (HEAD: c73cb25) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/455275 to see it. Tip: You can toggle comments from me using the |
|
This PR (HEAD: 4f7f78d) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/455275 to see it. Tip: You can toggle comments from me using the |
|
This PR (HEAD: a431ad1) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/455275 to see it. Tip: You can toggle comments from me using the |
|
This PR (HEAD: f6b504c) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/455275 to see it. Tip: You can toggle comments from me using the |
|
This PR (HEAD: 445464f) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/455275 to see it. Tip: You can toggle comments from me using the |
|
This PR (HEAD: 4b78ce8) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/455275 to see it. Tip: You can toggle comments from me using the |
|
This PR (HEAD: 32f3d80) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/455275 to see it. Tip: You can toggle comments from me using the |
|
Message from Damien Neil: Patch Set 9: Run-TryBot+1 (11 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. |
|
Message from Gopher Robot: Patch Set 9: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. |
|
Message from Gopher Robot: Patch Set 9: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. |
|
Message from Gopher Robot: Patch Set 9: TryBot-Result-1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. |
|
This PR (HEAD: 4a0bf94) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/455275 to see it. Tip: You can toggle comments from me using the |
|
Message from Mateusz Poliwczak: Patch Set 9: (6 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. |
This fixes following issues:
the current windows implementation, see:
net: make LookupCNAME consistent between Unix and Windows, document #50101 (comment)
of the package.
the go resolver when resSearch fails with an error.
(I am still unsure if this is going to work on all systems,
because of possible h_errno)
Currently return noSuchHost from resSearch on glibc systems,
it has a per-thread h_errno macro and it sets errno when resSearch
fails, so we can get a correct cause of the failure.
DO NOT REVIEW
DO NOT SUBMIT