Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Netlify builds happen for PRs that do not change docs #100072

Open
sobolevn opened this issue Dec 7, 2022 · 3 comments
Open

Netlify builds happen for PRs that do not change docs #100072

sobolevn opened this issue Dec 7, 2022 · 3 comments
Assignees
@sobolevn
Labels
build The build process and cross-build docs Documentation in the Doc dir type-bug An unexpected behavior, bug, or error

Comments

@sobolevn
Copy link
Member

sobolevn commented Dec 7, 2022 •
edited by bedevere-bot

Bug report

After #92852 all PRs get a notification from netlify about new doc builds. Example: #100070 (notice no Doc/ changes made)

I don't think it is right:

  1. We are wasting resources for no good reason
  2. It is a noise for both contributors and core devs

But, netlify has build.ignore option that can work similarly to these lines:

cpython/.github/workflows/doc.yml

Lines 23 to 26 in 7031275

paths:
- 'Doc/**'
- 'Misc/**'
- '.github/workflows/doc.yml'

Docs: https://docs.netlify.com/configure-builds/ignore-builds/

I will send a PR to test it :)

Linked PRs
@sobolevn sobolevn added type-bug An unexpected behavior, bug, or error docs Documentation in the Doc dir build The build process and cross-build labels Dec 7, 2022
@sobolevn sobolevn self-assigned this Dec 7, 2022
@sobolevn sobolevn changed the title Netlify build happen for PR that do not change docs Netlify builds happen for PRs that do not change docs Dec 7, 2022
sobolevn added a commit to sobolevn/cpython that referenced this issue Dec 7, 2022
@sobolevn
pythongh-100072: only trigger netlify builds for doc changes
4bc124c
@bedevere-bot bedevere-bot mentioned this issue Dec 7, 2022
Merged
hugovk added a commit that referenced this issue Dec 7, 2022
@sobolevn @hugovk
gh-100072: only trigger netlify builds for doc changes (#100074)
d92407e 
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@sobolevn
Copy link
Member Author

sobolevn commented Dec 8, 2022

@hugovk looks like we haven't solved this. Example PR that should not have this message, but still received it: #100114

@hugovk
Copy link
Member

hugovk commented Dec 8, 2022

There's two things going on here.

First, deploys are now being cancelled, as a result of PR #100074. 👍

We can see that from the comment ("Deploy Preview for python-cpython-preview canceled"), the status checks ("Deploy canceled") and the logs:

3:05:11 PM: Detected ignore command in Netlify configuration file. Proceeding with the specified command: 'git diff --quiet $CACHED_COMMIT_REF $COMMIT_REF . ../netlify.toml'
3:05:11 PM: User-specified ignore command returned exit code 0. Returning early from build.
3:05:11 PM: Creating deploy upload records
3:05:11 PM: Failed during stage 'checking build content for changes': Canceled build due to no content change

Second, the deploy notifications need to be turned off. I think this can only be done in the admin settings on Netlify, rather than config, and only one person currently has access, but hopefully we'll get more soon.

@sobolevn
Copy link
Member Author

sobolevn commented Dec 8, 2022

Yes, looks like it: https://docs.netlify.com/site-deploys/notifications/#github-pull-request-comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sobolevn sobolevn

Labels
build The build process and cross-build docs Documentation in the Doc dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hugovk @sobolevn