6.3
Name already in use
Commits on Dec 13, 2022
-
* 6.2: [ExpressionLanguage] Fix BC of cached SerializedParsedExpression containing GetAttrNode [HttpKernel] Fix CacheAttributeListener priority [DependencyInjection] Fix bug when tag name is a text node [VarExporter] Fix adding a key to an uninitialized array Fix missing command not matching namespace error message [SecurityBundle] Fix authenticator existence check in `Security::login()` [TwigBundle] Alias BodyRendererInterface Point `Security::*` constants to `SecurityRequestAttributes::*` ones [Translation] Fix extraction when dealing with VariadicPlaceholder parameters
-
bug #48559 [ExpressionLanguage] Fix BC of cached SerializedParsedExpr…
…ession containing GetAttrNode (fancyweb) This PR was merged into the 6.2 branch. Discussion ---------- [ExpressionLanguage] Fix BC of cached SerializedParsedExpression containing GetAttrNode | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | #48543 | License | MIT | Doc PR | - Ref #47058 `GetAttrNode` can be serialized and cached through `SerializedParsedExpression`. `@fsevestre` Can you try this small patch plz? Commits ------- 6c33582 [ExpressionLanguage] Fix BC of cached SerializedParsedExpression containing GetAttrNode
-
[ExpressionLanguage] Fix BC of cached SerializedParsedExpression cont…
…aining GetAttrNode
-
bug #48524 [HttpKernel] Fix
CacheAttributeListener
priority (HypeMC)This PR was merged into the 6.2 branch. Discussion ---------- [HttpKernel] Fix `CacheAttributeListener` priority | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Currently the `CacheAttributeListener` & the `IsGrantedAttributeListener` have the same priority: ``` Registered Listeners for "kernel.controller_arguments" Event ============================================================ ------- --------------------------------------------------------------------------------------------------------- ---------- Order Callable Priority ------- --------------------------------------------------------------------------------------------------------- ---------- #1 Symfony\Component\HttpKernel\EventListener\CacheAttributeListener::onKernelControllerArguments() 10 #2 Symfony\Component\Security\Http\EventListener\IsGrantedAttributeListener::onKernelControllerArguments() 10 #3 Symfony\Component\HttpKernel\EventListener\ErrorListener::onControllerArguments() 0 ------- --------------------------------------------------------------------------------------------------------- ---------- ``` Since the `CacheAttributeListener` is alphabetically first, it's first to get triggered. This can cause an unauthenticated user to receive a 304 Not modified instead of a 302 Redirect, resulting in the user seeing some stale content from when they were authenticated instead of getting redirected to the login page. This PR changes the priority of the `CacheAttributeListener` to be lower than that of the `IsGrantedAttributeListener`. Commits ------- 90eb89f [HttpKernel] Fix CacheAttributeListener priority
-
bug #48451 [Translation] Fix extraction when dealing with VariadicPla…
…ceholder parameters (Kocal) This PR was merged into the 6.2 branch. Discussion ---------- [Translation] Fix extraction when dealing with VariadicPlaceholder parameters | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | Fix #48422 <!-- prefix each issue number with "Fix #", no need to create an issue if none exists, explain below instead --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> I don't have the time for now to check if the command has tests or not, but dealing with raw args with + filtering for `Node\Arg` instance make the `extract` command working again. The issue is "caused by" https://github.com/symfony/symfony/blob/6.3/src/Symfony/Bridge/Twig/Extension/TranslationExtension.php#L71, the extract command is not able to deal with VariadicPlaceholder node. Changing to `[$this, 'trans']` works, but this is not the wanted solution. **Before:** ``` symfony console translation:extract fr --force -vvv Translation Messages Extractor and Dumper ========================================= // Generating "fr" translation files for "default directory" // Parsing templates... In CallLike.php line 36: [AssertionError (1)] assert(!$this->isFirstClassCallable()) Exception trace: at /Users/kocal/workspace/chronos/vendor/nikic/php-parser/lib/PhpParser/Node/Expr/CallLike.php:36 assert() at /Users/kocal/workspace/chronos/vendor/nikic/php-parser/lib/PhpParser/Node/Expr/CallLike.php:36 PhpParser\Node\Expr\CallLike->getArgs() at /Users/kocal/workspace/chronos/vendor/symfony/translation/Extractor/Visitor/AbstractVisitor.php:66 Symfony\Component\Translation\Extractor\Visitor\AbstractVisitor->hasNodeNamedArguments() at /Users/kocal/workspace/chronos/vendor/symfony/translation/Extractor/Visitor/TransMethodVisitor.php:40 Symfony\Component\Translation\Extractor\Visitor\TransMethodVisitor->enterNode() at /Users/kocal/workspace/chronos/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:123 PhpParser\NodeTraverser->traverseNode() at /Users/kocal/workspace/chronos/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:223 PhpParser\NodeTraverser->traverseArray() at /Users/kocal/workspace/chronos/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:114 PhpParser\NodeTraverser->traverseNode() at /Users/kocal/workspace/chronos/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:146 PhpParser\NodeTraverser->traverseNode() at /Users/kocal/workspace/chronos/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:223 PhpParser\NodeTraverser->traverseArray() at /Users/kocal/workspace/chronos/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:114 PhpParser\NodeTraverser->traverseNode() at /Users/kocal/workspace/chronos/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:146 PhpParser\NodeTraverser->traverseNode() at /Users/kocal/workspace/chronos/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:223 PhpParser\NodeTraverser->traverseArray() at /Users/kocal/workspace/chronos/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:114 PhpParser\NodeTraverser->traverseNode() at /Users/kocal/workspace/chronos/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:223 PhpParser\NodeTraverser->traverseArray() at /Users/kocal/workspace/chronos/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:114 PhpParser\NodeTraverser->traverseNode() at /Users/kocal/workspace/chronos/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:223 PhpParser\NodeTraverser->traverseArray() at /Users/kocal/workspace/chronos/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:114 PhpParser\NodeTraverser->traverseNode() at /Users/kocal/workspace/chronos/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:223 PhpParser\NodeTraverser->traverseArray() at /Users/kocal/workspace/chronos/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:91 PhpParser\NodeTraverser->traverse() at /Users/kocal/workspace/chronos/vendor/symfony/translation/Extractor/PhpAstExtractor.php:56 Symfony\Component\Translation\Extractor\PhpAstExtractor->extract() at /Users/kocal/workspace/chronos/vendor/symfony/translation/Extractor/ChainExtractor.php:48 Symfony\Component\Translation\Extractor\ChainExtractor->extract() at /Users/kocal/workspace/chronos/vendor/symfony/framework-bundle/Command/TranslationUpdateCommand.php:395 Symfony\Bundle\FrameworkBundle\Command\TranslationUpdateCommand->extractMessages() at /Users/kocal/workspace/chronos/vendor/symfony/framework-bundle/Command/TranslationUpdateCommand.php:200 Symfony\Bundle\FrameworkBundle\Command\TranslationUpdateCommand->execute() at /Users/kocal/workspace/chronos/vendor/symfony/console/Command/Command.php:312 Symfony\Component\Console\Command\Command->run() at /Users/kocal/workspace/chronos/vendor/symfony/console/Application.php:1038 Symfony\Component\Console\Application->doRunCommand() at /Users/kocal/workspace/chronos/vendor/symfony/framework-bundle/Console/Application.php:88 Symfony\Bundle\FrameworkBundle\Console\Application->doRunCommand() at /Users/kocal/workspace/chronos/vendor/symfony/console/Application.php:312 Symfony\Component\Console\Application->doRun() at /Users/kocal/workspace/chronos/vendor/symfony/framework-bundle/Console/Application.php:77 Symfony\Bundle\FrameworkBundle\Console\Application->doRun() at /Users/kocal/workspace/chronos/vendor/symfony/console/Application.php:168 Symfony\Component\Console\Application->run() at /Users/kocal/workspace/chronos/vendor/symfony/runtime/Runner/Symfony/ConsoleApplicationRunner.php:54 Symfony\Component\Runtime\Runner\Symfony\ConsoleApplicationRunner->run() at /Users/kocal/workspace/chronos/vendor/autoload_runtime.php:29 ``` **After:** ``` symfony console translation:extract fr --force -vvv Translation Messages Extractor and Dumper ========================================= // Generating "fr" translation files for "default directory" // Parsing templates... // Loading translation files... // Writing files... [OK] Translation files were successfully updated. ``` Commits ------- 2030c26 [Translation] Fix extraction when dealing with VariadicPlaceholder parameters
-
-
bug #48601 [SecurityBundle] Fix authenticator existence check in `Sec…
…urity::login()` (chalasr) This PR was merged into the 6.2 branch. Discussion ---------- [SecurityBundle] Fix authenticator existence check in `Security::login()` | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #48595 | License | MIT | Doc PR | - Commits ------- 97fe54d [SecurityBundle] Fix authenticator existence check in `Security::login()`
-
bug #48587 [TwigBundle] Alias BodyRendererInterface (n3o77)
This PR was merged into the 6.2 branch. Discussion ---------- [TwigBundle] Alias BodyRendererInterface | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | In the [Sending Messages Async](https://symfony.com/doc/current/mailer.html#sending-messages-async) ( symfony/symfony-docs@4fbbc16 ) docs the BodyRenderer is mentioned and used in the example. But there's no alias yet, not sure if this was intentional `@fabpot`? But it would be nice if it works right away without the need to add the alias manually. Commits ------- 248e792 [TwigBundle] Alias BodyRendererInterface
-
bug #48580 [Console] Fix missing command not matching namespace error…
… message (Titouan Galopin) This PR was merged into the 6.2 branch. Discussion ---------- [Console] Fix missing command not matching namespace error message | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix for #47750 | License | MIT | Doc PR | - Following #47750, running a command with an exception not related to the console (for instance fatal error) could end up in a situation where the error handling code doesn't stop the execution flow and result in: ``` In Application.php line 307: [ErrorException] Warning: Undefined variable $command ``` This fixes this behavior by throwing the original exception when no other error handling cases could handle the problem. Commits ------- 1e7202d Fix missing command not matching namespace error message
-
bug #48449 [DependencyInjection] Fix bug when tag name is a text node…
… (BrandonlinU) This PR was squashed before being merged into the 6.2 branch. Discussion ---------- [DependencyInjection] Fix bug when tag name is a text node | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #48445 | License | MIT Following the discussion in the ticket, I added a test for a tag without name attribute and content inside the tag for the name. I use `$tag->childElementCount !== 0` instead of `$tag->hasChildNode()` to detect if a `<attribute>` tag is present in the tag definition, or is only the name of the tag. Commits ------- b9337f1 [DependencyInjection] Fix bug when tag name is a text node
-
-
feature #48275 [FrameworkBundle] Allow to avoid
limit
definition in…… a RateLimiter configuration when using the `no_limit` policy (alexandre-daubois) This PR was merged into the 6.3 branch. Discussion ---------- [FrameworkBundle] Allow to avoid `limit` definition in a RateLimiter configuration when using the `no_limit` policy | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Fix #48268 | License | MIT | Doc PR | N/A As stated in the issue, DX will be improved if we can avoid setting a `limit` when using `no_limit` policy. Targets 6.3, as it can be considered as a feature. Commits ------- cd02eac [FrameworkBundle][DX] Allow to avoid `limit` definition in a RateLimiter configuration when using the `no_limit` policy
-
[FrameworkBundle][DX] Allow to avoid
limit
definition in a RateLimi……ter configuration when using the `no_limit` policy
-
-
minor #48613 [Console] Fixed typo (lyrixx)
This PR was merged into the 6.3 branch. Discussion ---------- [Console] Fixed typo | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | I left a comment that has nothing to do with this test. I'm sorry. Commits ------- 9a248c4 [Console] Fixed typo
-
bug #48608 [HttpKernel] fix wrong deprecation message (soyuka)
This PR was merged into the 6.3 branch. Discussion ---------- [HttpKernel] fix wrong deprecation message | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | yes | New feature? | no | License | MIT Introduced in #47680 Not sure about how to catch the deprecation. Commits ------- 6bfc18d [HttpKernel] fix wrong deprecation message
-
Commits on Dec 12, 2022
-
-
bug #48605 [VarExporter] Fix adding a key to an uninitialized array (…
…nicolas-grekas) This PR was merged into the 6.2 branch. Discussion ---------- [VarExporter] Fix adding a key to an uninitialized array | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | #48562 | License | MIT | Doc PR | - Commits ------- 57c6a62 [VarExporter] Fix adding a key to an uninitialized array
-
Commits on Dec 11, 2022
-
minor #48599 [VarDumper] Update types for dd() (derrabus)
This PR was merged into the 6.3 branch. Discussion ---------- [VarDumper] Update types for dd() | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | N/A Our beloved `dd()` function gets the PHP 8.1 treatment it deserves.
🚀 Commits ------- f7e4693 Update types for dd() -
Fix missing command not matching namespace error message
Titouan Galopin committedDec 11, 2022 -
-
feature #39353 [FrameworkBundle][Notifier] Allow to configure or disa…
…ble the message bus to use (jschaedl, fabpot) This PR was merged into the 6.3 branch. Discussion ---------- [FrameworkBundle][Notifier] Allow to configure or disable the message bus to use | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | yes <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | - <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT | Doc PR | tbd <!-- required for new features --> For the mailer integration there is already a possibility to disable or configure the `message_bus` to use. See: #34633 and #34648 This PR introduces a similar config option `notifier.message_bus` for the notifier integration. Things done: - [x] Add a config option `notifier.message_bus` for the notifier configuration - [x] Adjust FrameworkExtension considering the new `message_bus` config option - [x] Add tests for the new config option Commits ------- fc7aaa6 Fix logic and tests 215e802 Allow to configure or disable the message bus to use
Commits on Dec 9, 2022
-
-
bug #48554 [Security] Fix invalid deprecation messages in Security co…
…nstants (IonBazan) This PR was merged into the 6.2 branch. Discussion ---------- [Security] Fix invalid deprecation messages in Security constants | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - This PR changes invalid deprecation message, suggesting to use `\Symfony\Bundle\SecurityBundle\Security::ACCESS_DENIED_ERROR` instead of `\Symfony\Component\Security\Core\Security::ACCESS_DENIED_ERROR`, while `\Symfony\Component\Security\Http\SecurityRequestAttributes::ACCESS_DENIED_ERROR` should be used. For reference: #47760 Commits ------- 3fd5a40 Point `Security::*` constants to `SecurityRequestAttributes::*` ones
-
minor #48578 [Console] Fix tests (chalasr)
This PR was merged into the 6.3 branch. Discussion ---------- [Console] Fix tests | Q | A | ------------- | --- | Branch? | 6.3 for features / 5.4, 6.0, 6.1, or 6.2 for bug fixes <!-- see below --> | Bug fix? | yes/no | New feature? | yes/no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | yes/no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exists, explain below instead --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> <!-- Replace this notice by a short README for your feature/bugfix. This will help reviewers and should be a good start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the latest branch. - For new features, provide some code snippets to help understand usage. - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility (see https://symfony.com/bc). --> Commits ------- 82d79b4 [Console] Fix tests
-
* 6.2: [Clock] fix usleep deprecation warning [Cache] sync Redis6Proxy with upstream [HttpFoundation] IPv4-mapped IPv6 addresses incorrectly rejected Minor (comment only), part 2 [RateLimiter] Add typecast to Reservation::wait chore: fix syntax error [FrameworkBundle] add `kernel.locale_aware` tag to `LocaleSwitcher` [FrameworkBundle] Remove check of undefined service in mailer assertions [VarDumper] Ignore \Error in __debugInfo()
-
* 6.1: [HttpFoundation] IPv4-mapped IPv6 addresses incorrectly rejected Minor (comment only), part 2 [RateLimiter] Add typecast to Reservation::wait [FrameworkBundle] add `kernel.locale_aware` tag to `LocaleSwitcher` [FrameworkBundle] Remove check of undefined service in mailer assertions [VarDumper] Ignore \Error in __debugInfo()
-
* 6.0: [HttpFoundation] IPv4-mapped IPv6 addresses incorrectly rejected Minor (comment only), part 2 [RateLimiter] Add typecast to Reservation::wait [FrameworkBundle] Remove check of undefined service in mailer assertions [VarDumper] Ignore \Error in __debugInfo()
-
* 5.4: [HttpFoundation] IPv4-mapped IPv6 addresses incorrectly rejected [RateLimiter] Add typecast to Reservation::wait [VarDumper] Ignore \Error in __debugInfo()
-
-
bug #48538 [Clock] Fix
usleep
deprecation warning (victor-prdh)This PR was merged into the 6.2 branch. Discussion ---------- [Clock] Fix `usleep` deprecation warning | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #48537 | License | MIT | Doc PR | / Hi, As explained in the issue, i just makes the cast explicit from float to int and avoid deprecation warning Commits ------- d73459e [Clock] fix usleep deprecation warning
-