-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[WebProfilerBundle] Add intercept redirects configuration from toolbar #47663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
To me, the convenience it brings is not worth the added code complexity and maintenance while you could already do |
I agree with the previous comment. In any case, I'm not comfortable with adding configuration in the web profiler directly. |
I agree with the added complexity. Without taking a look at the code base, my first idea was that I would be able to add this feature as part as an external bundle. After seeing this long chain of Such a feature could be easily inserted in the listener logic if this long Would this be an improvement that appeals to you ? |
I'm divided about this (as Fabien, I don't like to add config in the toolbar ... but as upvotes showed, this specific option shortcut would be convenient sometimes). After thinking about this, I think my vote would be 👎 In addition to the added complexity, this could be used in the future to add more config options directly in the toolbar. Moreover, this introduces a mismatch between your Symfony config files and the Symfony behavior (e.g. you have In any case, I appreciate the effort that you put on creating this pull request. |
Thank you for this suggestion. I like the idea. I suggest to close this PR now and then reopen the idea as soon as we know a good architecture/strategy for options. |
Same here, I don't expect content that is not purely informational in this area. Closing, thanks for proposing. |
This PR adds a convenient way to override the WebProfilter intercept_redirects settings from the frontend toolbar.
When the need come to intercept redirect when developing applications, one need to edit the
config/packages/web_profiler.yaml
file (risking to commit it by mistake).With this PR addition, a single click on a checkbox added to the toolbar config tab will change the
intercept_redirects
settings for the current browser session as seen in the following screenshot.This feature was inspired by django's Web Debug Toolbar intercept redirect functionality which can also be triggered from the frontend part of the application.