[Yaml] Fix Yaml Parser with quote end in a new line #48022
Conversation
|
Hey! I think @mamazu has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
maxbeckers
force-pushed
the
patch-33082
branch
2 times, most recently
from
67e40af
to
b3cc966
Compare
nicolas-grekas
force-pushed
the
patch-33082
branch
from
b3cc966
to
50250dc
Compare
| foo: | ||
| bar: 'baz | ||
|
|
||
| ' |
There was a problem hiding this comment.
This is not valid YAML AFAIU. The quote must be indented.
There was a problem hiding this comment.
Then we should close this PR and the issue with "Won't fix", because this is exactly the case, what is requested to be fixed!
There was a problem hiding this comment.
If I am not mistaken, this is indeed valid YAML.
There was a problem hiding this comment.
I have taken some time to read up on this YAML topic. In the internet are two kinds of YAML parser for this topic. Either the content must be indented even if it is in quotes or everything in quotes can be indented free, because the part in quotes is simply considered as a text block.
What I want to say is that the PR should not be merged as it is and we should decide here how to proceed.
Solution A: everything should be how it is and we only support indented quotes, seems to be how it's described in the spec https://yaml.org/spec/1.2.2/#8111-block-indentation-indicator.
foo:
bar: 'baz
'
Solution B: be a bit more generous and allow what requested in the issue and how a lot of online parsers/validators see the quoted part as a string and allow stuff like that:
foo:
bar: 'baz1
baz2
baz3
'
Based on that I'd prefer solution A and keep it how it is as @fabpot mentioned. What do you think?
This is a fix for issue #33082.
The bug described in the ticket breaks on a ending quote in a new line:
Before the fix:
Symfony\Component\Yaml\Exception\ParseException: Malformed inline YAML string: 'baz at line 4.There was already a PR #33119, which was closed because of problems.