[ExpressionLanguage] Fix BC of cached SerializedParsedExpression containing GetAttrNode #48559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fancyweb
commented
Dec 9, 2022
|
|
||
| public function __unserialize(array $data): void | ||
| { | ||
| $this->nodes = $data['nodes']; |
There was a problem hiding this comment.
@nicolas-grekas I'm wondering if there's a way to just call the "default PHP unserialization" in one line and then add the extra checks?
There was a problem hiding this comment.
on a closer look, the code is correct (except for isNullCoalesce which has never been part of any serialized payloads)
|
Hello, I can confirm that with the current patch my error is gone |
…aining GetAttrNode
nicolas-grekas
force-pushed
the
el/fix-get-attr-node-uns
branch
from
fb817ee
to
6c33582
Compare
|
Thank you @fancyweb. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Ref #47058
GetAttrNodecan be serialized and cached throughSerializedParsedExpression.@fsevestre Can you try this small patch plz?