[FrameworkBundle] Allow to avoid limit definition in a RateLimiter configuration when using the no_limit policy
#48275
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
added
Status: Needs Review
Bug
DX
carsonbot
changed the title
limit definition in a RateLimiter configuration when using the no_limit policylimit definition in a RateLimiter configuration when using the no_limit policy
alexandre-daubois
force-pushed
the
fix/ratelimiter-no-limit
branch
from
c4db134
to
da026ea
Compare
|
This PR should target 6.3. |
alexandre-daubois
force-pushed
the
fix/ratelimiter-no-limit
branch
2 times, most recently
from
ae43058
to
38448c5
Compare
|
Updated base branch + added the related CHANGELOG.md entry. |
|
This seems like a bugfix to me |
|
@MatTheCat I understand your point of view and went for a bugfix as well at first sight. Fundamentally, the |
nicolas-grekas
force-pushed
the
fix/ratelimiter-no-limit
branch
from
38448c5
to
3d4b8d5
Compare
nicolas-grekas
approved these changes
Dec 13, 2022
| @@ -2119,6 +2118,10 @@ private function addRateLimiterSection(ArrayNodeDefinition $rootNode, callable $ | |||
| ->end() | |||
| ->end() | |||
| ->end() | |||
| ->validate() | |||
| ->ifTrue(function ($v) { return 'no_limit' !== $v['policy'] && null === ($v['limit'] ?? null); }) | |||
There was a problem hiding this comment.
!isset() is just fine, let's not use fancy syntax when not needed.
…ter configuration when using the `no_limit` policy
nicolas-grekas
force-pushed
the
fix/ratelimiter-no-limit
branch
from
3d4b8d5
to
cd02eac
Compare
|
Thank you @alexandre-daubois. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
As stated in the issue, DX will be improved if we can avoid setting a
limitwhen usingno_limitpolicy.Targets 6.3, as it can be considered as a feature.