Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESI fragment disable the profiler performance tab (stopwatch) #46687

Open
McLone opened this issue Jun 15, 2022 · 9 comments
Open

ESI fragment disable the profiler performance tab (stopwatch) #46687

McLone opened this issue Jun 15, 2022 · 9 comments
Labels
Bug Help wanted Issues and PRs which are looking for volunteers to complete them. HttpKernel Status: Needs Review

Comments

@McLone
Copy link

McLone commented Jun 15, 2022

Symfony version(s) affected

5.4.9

Description

If a page include a render_esi, with esi and symfony reverse proxy enabled, the timing section of the profiler bar displays "n/a ms".
Clicking on it display the performance tab with the message "No timing events have been recorded. Check that symfony/stopwatch is installed and debugging enabled in the kernel.".

How to reproduce

In templates/base.html.twig, if you change render_esi to a simple render, the timing section works again.

Possible Solution

No response

Additional Context

No response
@McLone McLone added the Bug label Jun 15, 2022
@carsonbot
Copy link

Hey, thanks for your report!
There has not been a lot of activity here for a while. Is this bug still relevant? Have you managed to find a workaround?

@carsonbot
Copy link

Could I get a reply or should I close this?

@carsonbot
Copy link

Hey,

I didn't hear anything so I'm going to close it. Feel free to comment if this is still relevant, I can always reopen!

@rglozman
Copy link

@carlcasbolt this bug still exists, I'm using version 6.3 and any page with an edge side include disables profiler performance tab (stopwatch). If you could take a look at this it would be greatly appreciated, makes profiling and debugging much harder.

@AsfalothDE
Copy link

I have the same issue, still with 5.4.31...

@GromNaN
Copy link
Member

GromNaN commented Nov 27, 2023

Issue confirmed with the provided reproducer.

@GromNaN GromNaN reopened this Nov 27, 2023
@carsonbot carsonbot removed the Stalled label Nov 27, 2023
@GromNaN GromNaN added the Help wanted Issues and PRs which are looking for volunteers to complete them. label Nov 27, 2023
@ankahla
Copy link

ankahla commented Feb 6, 2024

@GromNaN I have the same issue with version 5.4.33 and the only solution that I found is to replace render_esi by render

@MatTheCat
Copy link
Contributor

This happens because the HttpCache will reset the kernel by booting it when fetching the fragment. Not sure what could be done here.

@MatTheCat
Copy link
Contributor

MatTheCat commented May 19, 2024 •
edited
Loading

(Note that you can always clear the kernel.reset tag from the profiler and debug.stopwatch services using a compiler pass.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Help wanted Issues and PRs which are looking for volunteers to complete them. HttpKernel Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@GromNaN @McLone @MatTheCat @xabbuh @ankahla @rglozman @carsonbot @AsfalothDE