Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DependencyInjection] Don't autoconfigure tag when it's already set with attributes #48027

Merged
merged 1 commit into from Nov 1, 2022

Conversation

nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented Oct 28, 2022

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #48019
License MIT
Doc PR -

@carsonbot
Copy link

carsonbot commented Oct 29, 2022

Hey!

I think @deguif has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

Tobion
Tobion approved these changes Oct 29, 2022
@fabpot
Copy link
Member

fabpot commented Nov 1, 2022

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 67e0e87 into symfony:5.4 Nov 1, 2022
10 of 11 checks passed
@nicolas-grekas nicolas-grekas deleted the di-autoconf branch Nov 14, 2022
@fabpot fabpot mentioned this pull request Nov 19, 2022
This was referenced Nov 28, 2022
nicolas-grekas added a commit to nicolas-grekas/symfony that referenced this pull request Dec 5, 2022
…ag when it's already set with attributes (nicolas-grekas)"

This reverts commit 67e0e87, reversing
changes made to f9eaefa.
nicolas-grekas added a commit that referenced this pull request Dec 5, 2022
…re tag when it's already set with attributes" (nicolas-grekas)

This PR was merged into the 5.4 branch.

Discussion
----------

[DependencyInjection] Revert "bug #48027 Don't autoconfigure tag when it's already set with attributes"

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? |
| Tickets       | Fix #48388
| License       | MIT
| Doc PR        | -

Reverting #48027, which is a regression.

Commits
-------

bd2780a Revert "bug #48027 [DependencyInjection] Don't autoconfigure tag when it's already set with attributes (nicolas-grekas)"
derrabus added a commit that referenced this pull request Dec 6, 2022
* 5.4:
  Revert "bug #48027 [DependencyInjection] Don't autoconfigure tag when it's already set with attributes (nicolas-grekas)"
derrabus added a commit that referenced this pull request Dec 6, 2022
* 6.0:
  Revert "bug #48027 [DependencyInjection] Don't autoconfigure tag when it's already set with attributes (nicolas-grekas)"
derrabus added a commit that referenced this pull request Dec 6, 2022
* 6.1:
  Revert "bug #48027 [DependencyInjection] Don't autoconfigure tag when it's already set with attributes (nicolas-grekas)"
derrabus added a commit that referenced this pull request Dec 6, 2022
* 6.2:
  Bump Symfony version to 6.2.2
  Update VERSION for 6.2.1
  Update CHANGELOG for 6.2.1
  [DependencyInjection] Fix `ContainerBuilder` stats env usage with enum
  [Mailer] Fix rendered templates for notifications
  [HttpKernel] Fix using entities with the #[Cache()] attribute
  [DependencyInjection] Remove refs that point to container.excluded services when allowed
  Revert "bug #48027 [DependencyInjection] Don't autoconfigure tag when it's already set with attributes (nicolas-grekas)"
  [WebProfilerBundle] Use same color as other icons for the close toolbar btn
  [Profiler] Fix the dump view panel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants