bpo-45639: Add webp and avif image formats to mimetypes #29259

kixorz · 2021-10-28T02:35:25Z

Modern image types webp and avif are not recognized by the mimetypes module.

Problem: Many tools are written in Python and running on macOS. Good example is the AWS CLI. Running commands like "s3 sync" will save files with .webp and .avif extensions with incorrect "binary/octet-stream" Content-Type to S3. This creates additional problems with serving these resources over HTTP.

The webp and avif image types are supported by most browsers:
https://caniuse.com/#feat=webp
https://caniuse.com/#feat=avif

While webp is fully supported and largely used, it is not officially registered with IANA.

Avif is currently less popular, but it is fully registered with IANA.
https://www.iana.org/assignments/media-types/media-types.xhtml

Please consider the attached GitHub PR as a fix to these MIME Content-Type issues.

https://bugs.python.org/issue45639

#89802

the-knights-who-say-ni · 2021-10-28T02:35:28Z

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@kixorz

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

kixorz · 2021-10-28T02:37:09Z

I actually signed the CLA.

merwok · 2021-10-30T17:27:21Z

wepb is already added in #23034 (and with proper alpha sorting in the list)

kixorz · 2021-10-31T01:42:33Z

I saw the other PR, but it's not merged yet. The addition in the commit in this PR is sorted by mime type as requested in comment in the file.

github-actions · 2021-12-01T00:08:04Z

This PR is stale because it has been open for 30 days with no activity.

MaxwellDupre

Agreed these are not new and should be added but could you add to test Lib/test/test_mimetypes.py please?

kixorz · 2022-02-01T18:50:53Z

Thank you. I'll add the test.

merwok · 2022-02-01T19:01:20Z

On second thoughts, one ticket and one PR to add both types is fine.

kixorz · 2022-02-01T19:25:06Z

I added the test.

merwok · 2022-02-02T02:48:43Z

Can you add a news note on this model: https://github.com/python/cpython/pull/24917/files#diff-068155607fe32979f71408456e0f3163740897c21e6b6da80c45ec59cc660424

You can use https://blurb-it.herokuapp.com/ or pip install blurb locally

TeamSpen210 · 2022-02-02T03:03:59Z

If webp is nonstandard, shouldn't it go in the non-strict dict instead?

kixorz · 2022-02-02T04:52:27Z

I think I added the news entry. Thanks for the guidance.

cpython-cla-bot · 2022-05-03T17:03:49Z

All commit authors signed the Contributor License Agreement.

JelleZijlstra

Thanks, and sorry this was left hanging for so long! We still have a few days until the 3.11 feature freeze, and I'd love to get this in.

A few small things:

You'll need to resign the CLA with our new process
As @TeamSpen210 says, webp is nonstandard and should be in the common_types list.
The docs build is failing because the blurb is missing a trailing newline.

bedevere-bot · 2022-05-03T17:11:45Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

kixorz · 2022-05-03T17:54:30Z

I have made the requested changes; please review again.

bedevere-bot · 2022-05-03T17:54:34Z

Thanks for making the requested changes!

@JelleZijlstra: please review the changes made to this pull request.

JelleZijlstra · 2022-05-03T18:19:50Z

@kixorz thanks for the change! The tests are failing now, I think webp needs to move elsewhere in the test suite because it's not recognized by default.

kixorz · 2022-05-03T19:16:03Z

I believe I fixed the tests.

JelleZijlstra · 2022-05-03T19:18:34Z

Lib/test/test_mimetypes.py

@@ -95,13 +95,16 @@ def test_non_standard_types(self):
        eq = self.assertEqual
        # First try strict
        eq(self.db.guess_type('foo.xul', strict=True), (None, None))
+        eq(self.db.guess_type('foo.xul', strict=True), (None, None))


This is duplicated

Suggested change

eq(self.db.guess_type('foo.xul', strict=True), (None, None))

kixorz · 2022-05-03T19:21:06Z

Thanks for checking it. Sorry, I missed it. Should be fine now.

kixorz · 2022-05-04T03:24:39Z

Thanks for merging my changes!

Changes were performed on integration and core. Resources: - https://www.iana.org/assignments/media-types/media-types.xhtml webp is still not listed there - python/cpython#29259 was merged 3 days ago

Add modern image formats to mimetypes

80c4f64

kixorz requested a review from a team as a code owner Oct 28, 2021

the-knights-who-say-ni added the CLA not signed label Oct 28, 2021

bedevere-bot added the awaiting review label Oct 28, 2021

the-knights-who-say-ni added CLA signed and removed CLA not signed labels Oct 28, 2021

github-actions bot added the stale Stale PR or inactive for long period of time. label Dec 1, 2021

MaxwellDupre suggested changes Feb 1, 2022

View changes

bedevere-bot added awaiting core review and removed awaiting review labels Feb 1, 2022

Modern image format mimetypes test

2140c63

merwok mentioned this pull request Feb 2, 2022

bpo-38902: Add image/webp to list of non-standard mimetypes #23034

Closed

merwok changed the title ~~bpo-45639: Add modern image formats to mimetypes~~ bpo-45639: Add webp and avif image formats to mimetypes Feb 2, 2022

📜🤖 Added by blurb_it.

b178286

Merge branch 'main' into modern_mime_imagetypes

72b7ffd

JelleZijlstra requested changes May 3, 2022

View changes

bedevere-bot removed the awaiting core review label May 3, 2022

bedevere-bot added the awaiting changes label May 3, 2022

kixorz added 2 commits May 3, 2022

Moving webp to common_types

944dfe2

Updated news with a newline

8b13a42

bedevere-bot added awaiting change review and removed awaiting changes labels May 3, 2022

bedevere-bot requested a review from JelleZijlstra May 3, 2022

JelleZijlstra approved these changes May 3, 2022

View changes

bedevere-bot added awaiting merge and removed awaiting change review labels May 3, 2022

JelleZijlstra self-assigned this May 3, 2022

Fixed tests

1258a52

JelleZijlstra reviewed May 3, 2022

View changes

Removed duped line

899d807

JelleZijlstra approved these changes May 3, 2022

View changes

JelleZijlstra merged commit 6dee695 into python:main May 3, 2022
13 checks passed

bedevere-bot removed the awaiting merge label May 3, 2022

kixorz mannequin mentioned this pull request May 3, 2022

Support webp and avif image formats in mimetypes #89802

Closed

kixorz deleted the modern_mime_imagetypes branch May 3, 2022

fcollonval mentioned this pull request Sep 9, 2022

Added mimeType for .webp image files jupyterlab/jupyterlab#13066

Merged

alec-kr mentioned this pull request Sep 10, 2022

Add support for custom MIME types jupyter-server/jupyter_server#968

Open

iritkatriel mentioned this pull request Nov 26, 2022

bpo-46456:Add '.avif' mime to 'image/avif' #30823

Closed

bpo-45639: Add webp and avif image formats to mimetypes #29259

bpo-45639: Add webp and avif image formats to mimetypes #29259

kixorz commented Oct 28, 2021 •

edited by JelleZijlstra

the-knights-who-say-ni commented Oct 28, 2021

kixorz commented Oct 28, 2021

merwok commented Oct 30, 2021

kixorz commented Oct 31, 2021

github-actions bot commented Dec 1, 2021

MaxwellDupre left a comment

kixorz commented Feb 1, 2022

merwok commented Feb 1, 2022

kixorz commented Feb 1, 2022

merwok commented Feb 2, 2022

TeamSpen210 commented Feb 2, 2022

kixorz commented Feb 2, 2022

cpython-cla-bot bot commented May 3, 2022 •

edited

JelleZijlstra left a comment

bedevere-bot commented May 3, 2022

kixorz commented May 3, 2022

bedevere-bot commented May 3, 2022

JelleZijlstra commented May 3, 2022

kixorz commented May 3, 2022

JelleZijlstra May 3, 2022

kixorz commented May 3, 2022

kixorz commented May 4, 2022

bpo-45639: Add webp and avif image formats to mimetypes #29259

bpo-45639: Add webp and avif image formats to mimetypes #29259

Conversation

kixorz commented Oct 28, 2021 • edited by JelleZijlstra

the-knights-who-say-ni commented Oct 28, 2021

CLA Missing

kixorz commented Oct 28, 2021

merwok commented Oct 30, 2021

kixorz commented Oct 31, 2021

github-actions bot commented Dec 1, 2021

MaxwellDupre left a comment

kixorz commented Feb 1, 2022

merwok commented Feb 1, 2022

kixorz commented Feb 1, 2022

merwok commented Feb 2, 2022

TeamSpen210 commented Feb 2, 2022

kixorz commented Feb 2, 2022

cpython-cla-bot bot commented May 3, 2022 • edited

JelleZijlstra left a comment

bedevere-bot commented May 3, 2022

kixorz commented May 3, 2022

bedevere-bot commented May 3, 2022

JelleZijlstra commented May 3, 2022

kixorz commented May 3, 2022

JelleZijlstra May 3, 2022

Choose a reason for hiding this comment

kixorz commented May 3, 2022

kixorz commented May 4, 2022

kixorz commented Oct 28, 2021 •

edited by JelleZijlstra

cpython-cla-bot bot commented May 3, 2022 •

edited