Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give minimum versions of all dependencies and test on them #320

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Give minimum versions of all dependencies and test on them #320

wants to merge 6 commits into from

Conversation

gsnedders
Copy link
Member

@gsnedders gsnedders commented Feb 19, 2017

No description provided.

@gsnedders
Copy link
Member Author

gsnedders commented Mar 17, 2017

This doesn't work because PIP_VERSION is consumed by PIP. Need to rename the env variable.

@willkg willkg added this to the 1.0 milestone Oct 3, 2017
@willkg
Copy link
Contributor

willkg commented Oct 31, 2017

I understand the gist of what this is trying to solve, but I think this is better solved with tox and environment matrixes.

I think we should close this out and reimplement it after the PR switching to tox has landed.

Regardless, I'm taking this out of the 1.0 milestone.

@willkg willkg removed this from the 1.0 milestone Oct 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gsnedders @willkg