Bump DescribeConfigs API to version 1 #888
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this change breaks the integration tests. I'm not quite sure how many people are using Kafka versions older than v1.1 – since there's no support for multiple versions of an API I'm generally conservative about bumping the required version. |
|
I can get the tests passing by updating a few expectations and skipping some specs for v1.0 / v0.11. But based on your comments it seems like maybe we don't want to go forward with this? We can probably just live with our monkey patch for now and work towards getting these APIs implemented in |
|
Pull request has been marked as stale due to a lack of activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 1 of this API exposes
config_sourcewhich describes the origin of a particular config (topic, broker, default value, etc). We have tooling that manages topic-level configs so being able to filter onconfig_sourcewould be very helpful.As far as I can tell,
DescribeConfigsis used in two places:describe_topicanddescribe_configs(broker configs). The former is noted to be an alpha API while the latter is not.I'm not sure about the compatibility goals of this library (version 1 of this API was introduced in Kafka 1.1.0), so I just wanted to start a conversation.
Reference: https://kafka.apache.org/protocol#The_Messages_DescribeConfigs