Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upload NEWS file as artifact #30419

Merged
merged 6 commits into from Nov 23, 2022
Merged

Upload NEWS file as artifact #30419

merged 6 commits into from Nov 23, 2022

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Jan 5, 2022

Fixes python/core-workflow#147.

Since that issue was opened, we've moved testing from Travis CI to GitHub Actions.

And more recently the blurb tool is now being as part of make build called as part of make ... doctest in the "Check documentation" step (#30009).

So let's also upload the generated NEWS file as an artifact so it can be inspected after the build.

For example, it's available to download here:

@hugovk hugovk mentioned this pull request Jan 5, 2022
Closed
erlend-aasland
erlend-aasland approved these changes Jan 6, 2022
View changes
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Neat!

@erlend-aasland erlend-aasland requested a review from Mariatta Jan 21, 2022
@hugovk
Copy link
Member Author

hugovk commented Feb 28, 2022

Conflict resolved!

Would be nice to get this merged, it'd make reviewing docs PRs much easier: can download the generated files rather than checking out the branch locally and building them manually.

@hugovk hugovk mentioned this pull request Mar 10, 2022
Merged
@hugovk hugovk mentioned this pull request Mar 19, 2022
Merged
@hugovk hugovk mentioned this pull request Apr 13, 2022
Merged
@hugovk
Copy link
Member Author

hugovk commented Jun 4, 2022

Conflict resolved!

merwok
merwok approved these changes Jun 4, 2022
View changes
@merwok merwok requested a review from ezio-melotti as a code owner Nov 22, 2022
@smontanaro
Copy link
Contributor

smontanaro commented Nov 22, 2022

(I'm working my way through some PRs which have been approved and are labeled "awaiting merge", hence my seemingly bolt from the blue comment. Why? Read here.)

Can this be merged or are you still waiting for @Mariatta and @ezio-melotti to review?

ezio-melotti
ezio-melotti reviewed Nov 22, 2022
View changes
Copy link
Member

@ezio-melotti ezio-melotti left a comment

Do we know how much storage is the python org using?
I don't expect the NEWS file to be particularly large, but if it gets generated for each PR it will add up and we might eventually reach the limit. We can also tweak the number of day the artifact is stored before being automatically deleted.

Other than that, the PR LGTM.

@hugovk
Copy link
Member Author

hugovk commented Nov 23, 2022

The current usage will be visible under https://github.com/organizations/python/settings/billing for org admins.

@hugovk
Copy link
Member Author

hugovk commented Nov 23, 2022

Also the NEWS file is only 2% the size of the docs artifact we've been uploading for a long time and apparently that's not been a problem.

image

ezio-melotti
ezio-melotti approved these changes Nov 23, 2022
View changes
Copy link
Member

@ezio-melotti ezio-melotti left a comment

In that case I guess it's not a problem. FWIW the artifact retention period is currently set at 90 days. We can lower it if space becomes a problem.

@ezio-melotti ezio-melotti merged commit 57dfb1c into python:main Nov 23, 2022
15 checks passed
@hugovk hugovk deleted the gha-blurb-upload-news branch Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettcannon brettcannon

@merwok merwok

@erlend-aasland erlend-aasland

@ezio-melotti ezio-melotti

@sumeshir26 sumeshir26

@Mariatta Mariatta

Assignees
No one assigned
Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run blurb as part of Travis
9 participants
@hugovk @smontanaro @brettcannon @merwok @erlend-aasland @ezio-melotti @sumeshir26 @the-knights-who-say-ni @bedevere-bot