gh-81057: Move Signal-Related Globals to _PyRuntimeState #100085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ericsnowcurrently
commented
Dec 7, 2022
•
- Issue: [subinterpreters] Global C variables are a problem #81057
|
| Name | Link |
|---|---|
| 38596a0 | |
| https://app.netlify.com/sites/python-cpython-preview/deploys/6397b5e1a4ac130008314bbc |
ericsnowcurrently
force-pushed
the
consolidate-signal-globals
branch
2 times, most recently
from
b8ae626
to
3b416b1
Compare
ericsnowcurrently
force-pushed
the
consolidate-signal-globals
branch
2 times, most recently
from
5cd67d8
to
c1ac129
Compare
ericsnowcurrently
commented
Dec 12, 2022
Include/internal/pycore_signal.h
Outdated
| #ifdef MS_WINDOWS | ||
| # ifdef PYCORE_SIGNAL_WITH_PRE_INCLUDES | ||
| # ifndef SOCKET | ||
| # error "<winsock2.h> must be included before this header" | ||
| # endif | ||
| # ifndef HANDLE | ||
| # error "<windows.h> must be included before this header" | ||
| # endif | ||
| # endif | ||
| #endif |
There was a problem hiding this comment.
@zooba, did I do this right? This is how I understood your recommendation.
There was a problem hiding this comment.
I don't think you want PYCORE_SIGNAL_WITH_PRE_INCLUDES in there. The header file is simply wrong if the system headers haven't been included, so it should always fail.
If the header needs to be used somewhere else, then that somewhere else also needs to include the headers. Alternatively, if it doesn't need to use the values (but just be able to allocate the structures), replace the SOCKET and HANDLE types entirely with void * and do casts anywhere they're actually being used.
This reverts commit d9a5dfa.
ericsnowcurrently
force-pushed
the
consolidate-signal-globals
branch
from
b8ff9df
to
08799ad
Compare
zooba
reviewed
Dec 12, 2022
zooba
reviewed
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.