Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-34605: Replace "pliant children" with "helpers" #9195

Merged
merged 1 commit into from Sep 11, 2018
Merged

bpo-34605: Replace "pliant children" with "helpers" #9195

merged 1 commit into from Sep 11, 2018

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Sep 11, 2018 •
edited by bedevere-bot

In distutils.command.install, replace "pliant children" (previously,
it was "pliant slaves") with "helpers".

https://bugs.python.org/issue34605

@vstinner
bpo-34605: Replace "pliant children" with "helpers"
9ba3a52 
In distutils.command.install, replace "pliant children" (previously,
it was "pliant slaves") with "helpers".
@vstinner vstinner requested review from gvanrossum and ericvsmith Sep 11, 2018
@vstinner vstinner mentioned this pull request Sep 11, 2018
Merged
pitrou
pitrou approved these changes Sep 11, 2018
View changes
@vstinner
Copy link
Member Author

vstinner commented Sep 11, 2018

Copy of @gvanrossum comment:

I Googled a bit and it seems "pliant slave" is an old-fashioned way to refer to slaves, and even more demeaning than just "slave" -- I presume it was meant ironically by the original author. We should really replace the entire construct "pliant slaves" with a more neutral term. I don't think "children" is the right term -- I propose "helpers".

#9101 (comment)

ericvsmith
ericvsmith approved these changes Sep 11, 2018
View changes
Copy link
Member

@ericvsmith ericvsmith left a comment

Looks good.

@gvanrossum gvanrossum added the 🤖 automerge PR will be merged once it's been approved and all CI passed label Sep 11, 2018
@miss-islington
Copy link
Contributor

miss-islington commented Sep 11, 2018

@vstinner: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit fa7dfae into python:master Sep 11, 2018
@vstinner vstinner deleted the pliant branch Sep 11, 2018
@peter-dolkens

This comment has been minimized.

Sign in to view
@brettcannon
Copy link
Member

brettcannon commented Sep 12, 2018

@dolkensp your insult at Victor about his English skills is uncalled for; you simply could have pointed out that SEO would be affected.

Consider this a warning that insulting people is not tolerated under the Code of Conduct and if it happens again there will be ramifications.

@python python locked as too heated and limited conversation to collaborators Sep 12, 2018
@pitrou
Copy link
Member

pitrou commented Sep 12, 2018

Interesting. As a non-native English speaker myself, I would say that hesitating between "childs" and "children" is a sign that maybe one should wait for comments before merging a language-tweaking PR. Just saying ;-)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ericvsmith ericvsmith

@pitrou pitrou

@gvanrossum gvanrossum

Assignees
No one assigned
Labels
🤖 automerge PR will be merged once it's been approved and all CI passed skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@vstinner @miss-islington @peter-dolkens @brettcannon @pitrou @ericvsmith @gvanrossum @the-knights-who-say-ni @bedevere-bot