bpo-44334: Use bytearray in urllib.unquote_to_bytes #26576
Conversation
In case of form contain very large data ( in my case the string to parse was about 6000000 byte ) Old code use list of bytes during parsing consumes a lot of memory New code will use bytearry , which use less memory
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
mostafadafatersa
changed the title
mostafadafatersa
changed the title
mostafadafatersa
requested review from
1st1,
abalkin,
asvetlov,
berkerpeksag,
brettcannon,
cjw296,
encukou,
ericsnowcurrently,
ericvsmith,
ethanfurman,
ezio-melotti,
gpshead,
gvanrossum,
ilevkivskyi,
isidentical,
lysnikolaou,
markshannon,
methane,
ncoghlan,
pablogsal,
pganssle,
rhettinger and
terryjreedy
as code owners
pganssle
removed request for
a team,
vsajip,
methane,
warsaw,
tiran,
abalkin,
ncoghlan,
pganssle,
rhettinger,
markshannon,
pablogsal and
terryjreedy
terryjreedy
changed the title
|
Before doing anything more, sign the CLA. Merging into 3.9 is not valid and is likely the reason for the spurious review requests. Make a new PR in which you create a branch from main and then compare and propose to merge it into main. Read devguide.python.org, which should make this clear. EDIT: Changing the base branch from 3.9 to main should have worked right if your patch-1 branch were a branch of main, but since it did not, it was perhaps a branch of 3.9 or something other than what it needed to be. Since the changes are few, start over with a fresh branch derived from main. |
In case of form contain very large data ( in my case the string to parse was about 6000000 byte )
Old code use list of bytes during parsing consumes a lot of memory
New code will use bytearry , which use less memory
https://bugs.python.org/issue44334