Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-98636: Fix detecting gdbm_compat for _dbm module #98643

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

gh-98636: Fix detecting gdbm_compat for _dbm module #98643

wants to merge 1 commit into from

Conversation

mgorny
Copy link
Contributor

@mgorny mgorny commented Oct 25, 2022 •
edited

Fix the gdbm_compat library detection logic to actually check for
-lgdbm_compat independently of the ndbm detection. This fixes the build
failure with --with-dbmliborder=gdbm, and implicit fallback to ndbm
with the default value.

@mgorny
Copy link
Contributor Author

mgorny commented Nov 4, 2022

Ping.

@mgorny
Copy link
Contributor Author

mgorny commented Dec 7, 2022

Another ping. It would be really nice to have this fixed.

@mgorny
pythongh-98636: Fix detecting gdbm_compat for _dbm module
7f446f0 
Fix the gdbm_compat library detection logic to actually check for
-lgdbm_compat independently of the ndbm detection.  This fixes the build
failure with `--with-dbmliborder=gdbm`, and implicit fallback to ndbm
with the default value.
@bedevere-bot bedevere-bot mentioned this pull request Dec 18, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiran tiran

@erlend-aasland erlend-aasland

Assignees
No one assigned
Labels
awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mgorny @bedevere-bot