Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation fix on code.py #17988

Merged
merged 2 commits into from Jan 14, 2020
Merged

Documentation fix on code.py #17988

merged 2 commits into from Jan 14, 2020
+2 −2

Conversation

@kylepollina
Copy link
Contributor

kylepollina commented Jan 13, 2020 •
edited

Small change to InteractiveInterpreter.runsource docstring to make it more readable.
@kylepollina
Documentation fix on code.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
2d8300a 
Small change to InteractiveInterpreter.runsource doc string to make it more readable.
@the-knights-who-say-ni

This comment has been minimized.

Sign in to view
Copy link

the-knights-who-say-ni commented Jan 13, 2020

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@kylepollina

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!
@tirkarthi
tirkarthi reviewed Jan 13, 2020
View changes
Copy link
Member

tirkarthi left a comment

The change looks correct to me. There is also similar sentence at Doc/library/code.rst that can be changed. It would be good if you can also sign the CLA. Thanks.
@eamanu
eamanu approved these changes Jan 14, 2020
View changes
Copy link
Contributor

eamanu left a comment

LGTM. +1 to @tirkarthi comments :)
@kylepollina
Minor docstring edit on code.rst
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3dbe482 
Added minor docstring edit to code.rst to make it more readable.
@kylepollina

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

kylepollina commented Jan 14, 2020 •
edited

Added similar change to Doc/library/code.rst as well
@kylepollina kylepollina requested a review from tirkarthi Jan 14, 2020
@tirkarthi
tirkarthi approved these changes Jan 14, 2020
View changes
Copy link
Member

tirkarthi left a comment

LGTM. Thanks.
@tirkarthi tirkarthi merged commit b4cdb3f into python:master Jan 14, 2020
9 checks passed
9 checks passed
Docs
Details
Windows (x86)
Details
Windows (x64)
Details
macOS
Details
Ubuntu
Details
Azure Pipelines PR #20200114.2 succeeded
Details
bedevere/issue-number Issue report skipped
bedevere/news "skip news" label found
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jan 14, 2020

Thanks @kylepollina for the PR, and @tirkarthi for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jan 14, 2020

Thanks @kylepollina for the PR, and @tirkarthi for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖
miss-islington added a commit to miss-islington/cpython that referenced this pull request Jan 14, 2020
@kylepollina @miss-islington
Fix documentation in code.py (pythonGH-17988)
8856954 
(cherry picked from commit b4cdb3f)

Co-authored-by: Kyle Pollina <kylepollina@protonmail.com>
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jan 14, 2020

GH-18001 is a backport of this pull request to the 3.7 branch.
miss-islington added a commit to miss-islington/cpython that referenced this pull request Jan 14, 2020
@kylepollina @miss-islington
Fix documentation in code.py (pythonGH-17988)
d64d018 
(cherry picked from commit b4cdb3f)

Co-authored-by: Kyle Pollina <kylepollina@protonmail.com>
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jan 14, 2020

GH-18002 is a backport of this pull request to the 3.8 branch.
miss-islington added a commit that referenced this pull request Jan 14, 2020
@miss-islington @kylepollina
Fix documentation in code.py (GH-17988)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9f220e4 
(cherry picked from commit b4cdb3f)

Co-authored-by: Kyle Pollina <kylepollina@protonmail.com>
miss-islington added a commit that referenced this pull request Jan 14, 2020
@miss-islington @kylepollina
Fix documentation in code.py (GH-17988)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5c08bfe 
(cherry picked from commit b4cdb3f)

Co-authored-by: Kyle Pollina <kylepollina@protonmail.com>
petdance added a commit to petdance/cpython that referenced this pull request Jan 17, 2020
@kylepollina @petdance
Fix documentation in code.py (pythonGH-17988)
9b0d468
petdance added a commit to petdance/cpython that referenced this pull request Jan 17, 2020
@kylepollina @petdance
Fix documentation in code.py (pythonGH-17988)
c82e377
petdance added a commit to petdance/cpython that referenced this pull request Jan 17, 2020
@kylepollina @petdance
Fix documentation in code.py (pythonGH-17988)
ed71470
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tirkarthi tirkarthi

@eamanu eamanu

Assignees
No one assigned
Labels
CLA signed skip issue skip news
Projects
None yet
Milestone
No milestone
6 participants
@kylepollina @the-knights-who-say-ni @miss-islington @bedevere-bot @tirkarthi @eamanu
You can’t perform that action at this time.