New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-40859: Update Windows build to use xz-5.2.5 #20622
Conversation
I'll get the sources pushed to the repo we use later tonight. (Can't seem to mark this as unread, so mention me again if it seems like I've forgotten.) |
in xz-5.2.2: $(lzmaDir)windows\config.h in xz-5.2.5: $(lzmaDir)windows\vs2019\config.h
The xz sources are up now, and I copied the config.h into the right place, so all should be fine. |
I updated project configure files, it works if don't copy |
Thanks @animalize for the PR, and @zooba for merging it |
Sorry, @animalize and @zooba, I could not cleanly backport this to |
The change for include directory isn't any worse than what we had before, but we might want to make it conditional on VS version if it starts breaking for people using earlier/later releases (though I don't see why there'd be differences between the files) |
GH-91714 is a backport of this pull request to the 3.10 branch. |
I compared, the contents of these 3 files are same, except the comment at the first line.
Earlier version MSVC can also use |
Co-authored-by: Ma Lin <animalize@users.noreply.github.com>
Co-authored-by: Ma Lin <animalize@users.noreply.github.com> (cherry picked from commit 73af4b0) Co-authored-by: Steve Dower <steve.dower@python.org>
https://bugs.python.org/issue40859