Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-97909: Fix markup for PyMethodDef members #100089

Merged
merged 6 commits into from Dec 17, 2022
Merged

Conversation

ramvikrams
Copy link
Contributor

@ramvikrams ramvikrams commented Dec 7, 2022

gh-97909: Updated the PyMethodDef doc

@netlify
Copy link

netlify bot commented Dec 7, 2022

Deploy Preview for python-cpython-preview ready!

Name Link
🔨 Latest commit 0d7fa54
🔍 Latest deploy log https://app.netlify.com/sites/python-cpython-preview/deploys/639458bdcd679800090aeac6
😎 Deploy Preview https://deploy-preview-100089--python-cpython-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Dec 7, 2022
@kumaraditya303 kumaraditya303 requested a review from encukou Dec 8, 2022
Doc/c-api/structures.rst Outdated Show resolved Hide resolved
@kumaraditya303 kumaraditya303 changed the title gh-97909: PyMethodDef members are not marked up gh-97909: Fix markup for PyMethodDef members Dec 17, 2022
@kumaraditya303 kumaraditya303 merged commit 8edcb30 into python:main Dec 17, 2022
15 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Dec 17, 2022

Thanks @ramvikrams for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒🤖

@bedevere-bot
Copy link

bedevere-bot commented Dec 17, 2022

GH-100311 is a backport of this pull request to the 3.11 branch.

@bedevere-bot
Copy link

bedevere-bot commented Dec 17, 2022

GH-100312 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 17, 2022
(cherry picked from commit 8edcb30)

Co-authored-by: ram vikram singh <ramvikrams243@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 17, 2022
(cherry picked from commit 8edcb30)

Co-authored-by: ram vikram singh <ramvikrams243@gmail.com>
@kumaraditya303
Copy link
Contributor

kumaraditya303 commented Dec 17, 2022

Thanks.

@ramvikrams
Copy link
Contributor Author

ramvikrams commented Dec 17, 2022

thanks to you

miss-islington added a commit that referenced this pull request Dec 17, 2022
(cherry picked from commit 8edcb30)

Co-authored-by: ram vikram singh <ramvikrams243@gmail.com>
miss-islington added a commit that referenced this pull request Dec 17, 2022
(cherry picked from commit 8edcb30)

Co-authored-by: ram vikram singh <ramvikrams243@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants