Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 650: Correct minor grammar mistake #2920

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

smwhite2
Copy link

@smwhite2 smwhite2 commented Dec 12, 2022

Correct a few minor grammar mistakes.

@smwhite2 smwhite2 requested a review from brettcannon as a code owner Dec 12, 2022
@CAM-Gerlach
Copy link
Member

CAM-Gerlach commented Dec 12, 2022

As mentioned in our Readme, Contributing Guide, PEP 1, PEP 12, etc., non-Draft Standards Track PEPs are generally considered historical documents and not generally modified after acceptance/rejection/withdrawal, outside of rendering/syntax errors or other special circumstances. In particular, this is a Withdrawn PEP, so there is little reason to change it, and it is far more valuable to direct the efforts of contributors and reviewers toward PEPs that are Draft or Active, where the changes are much more likely to mean something.

IMO, the conforming of typographical quotes to apostrophes (single quotes) adds diff noise for no meaningful change in the rendered output. As such, from a PEP editor perspective I'm not so fond of it at least as-is, but as it does also fix a small typo, I will leave it to the PEP author and editor @brettcannon to make the the final call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants