Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PTHREAD_SCOPE_SYSTEM configure check fails with Clang 16 (-Wimplicit-int) #99086

Closed
thesamesam opened this issue Nov 4, 2022 · 0 comments
Closed

PTHREAD_SCOPE_SYSTEM configure check fails with Clang 16 (-Wimplicit-int) #99086

thesamesam opened this issue Nov 4, 2022 · 0 comments
Labels
3.10 3.11 3.12 build The build process and cross-build type-bug An unexpected behavior, bug, or error

Comments

@thesamesam
Copy link
Contributor

thesamesam commented Nov 4, 2022 •
edited by bedevere-bot

Bug report

The PTHREAD_SCOPE_SYSTEM configure check lacks int before the main() definition and causes Clang to emit a -Wimplicit-int warning. This warning becomes an error by default with Clang 16+.

Your environment

  • CPython versions tested on: master
  • Operating system and architecture: Gentoo Linux amd64
  • Clang 16 (or Clang 15 with -Werror=implicit-int -Werror=implicit-function-declaration)
@thesamesam thesamesam added the type-bug An unexpected behavior, bug, or error label Nov 4, 2022
thesamesam added a commit to thesamesam/cpython that referenced this issue Nov 4, 2022
@thesamesam
pythongh-99086: Build: Fix -Wimplicit-int in PTHREAD_SCOPE_SYSTEM che…
6d9431f 
…ck (python#99085)

Clang 16 makes -Wimplicit-int fatal by default.

Avoids errors like:
```
conftest.c:142:7: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
```

Signed-off-by: Sam James <sam@gentoo.org>
@bedevere-bot bedevere-bot mentioned this issue Nov 4, 2022
Merged
thesamesam added a commit to thesamesam/cpython that referenced this issue Nov 4, 2022
@thesamesam
pythongh-99086: Build: Fix -Wimplicit-int in PTHREAD_SCOPE_SYSTEM che…
70b81e2 
…ck (python#99085)

Clang 16 makes -Wimplicit-int fatal by default.

Avoids errors like:
```
conftest.c:142:7: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
```

Signed-off-by: Sam James <sam@gentoo.org>
thesamesam added a commit to thesamesam/cpython that referenced this issue Nov 4, 2022
@thesamesam
pythongh-99086: Build: Fix -Wimplicit-int in PTHREAD_SCOPE_SYSTEM che…
b89a0f7 
…ck (python#99085)

Clang 16 makes -Wimplicit-int fatal by default.

Avoids errors like:
```
conftest.c:142:7: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
```

Signed-off-by: Sam James <sam@gentoo.org>
@kumaraditya303 kumaraditya303 added 3.11 3.10 3.12 build The build process and cross-build labels Nov 4, 2022
erlend-aasland pushed a commit that referenced this issue Nov 5, 2022
@thesamesam
gh-99086: Fix implicit int compiler warning in configure check for PT…
12078e7 
…HREAD_SCOPE_SYSTEM (#99085)
erlend-aasland pushed a commit to erlend-aasland/cpython that referenced this issue Nov 5, 2022
@thesamesam @erlend-aasland
[3.11] pythongh-99086: Fix implicit int compiler warning in configure…
8f073db 
… check for PTHREAD_SCOPE_SYSTEM (pythonGH-99085)

(cherry picked from commit 12078e7)

Co-authored-by: Sam James <sam@cmpct.info>
erlend-aasland pushed a commit to erlend-aasland/cpython that referenced this issue Nov 5, 2022
@thesamesam @erlend-aasland
[3.10] pythongh-99086: Fix implicit int compiler warning in configure…
51459a8 
… check for PTHREAD_SCOPE_SYSTEM (pythonGH-99085)

(cherry picked from commit 12078e7)

Co-authored-by: Sam James <sam@cmpct.info>
This was referenced Nov 5, 2022
Merged
Merged
erlend-aasland added a commit that referenced this issue Nov 5, 2022
@erlend-aasland @thesamesam
[3.11] gh-99086: Fix implicit int compiler warning in configure check…
573b451 
… for PTHREAD_SCOPE_SYSTEM (GH-99085) (#99118)

(cherry picked from commit 12078e7)

Co-authored-by: Sam James <sam@cmpct.info>
erlend-aasland added a commit that referenced this issue Nov 6, 2022
@erlend-aasland @thesamesam
[3.10] gh-99086: Fix implicit int compiler warning in configure check…
0d5b25b 
… for PTHREAD_SCOPE_SYSTEM (GH-99085) (#99119)

(cherry picked from commit 12078e7)

Co-authored-by: Sam James <sam@cmpct.info>

Co-authored-by: Sam James <sam@cmpct.info>
thesamesam added a commit to thesamesam/cpython that referenced this issue Nov 12, 2022
@thesamesam
pythongh-99086: Further -Wstrict-prototypes, -Wimplicit-function-decl…
97f6b5c 
…aration fixes

Followup to 12078e7. I ended up missing
a few, apparently.

Clang 16 makes -Wimplicit-function-declaration an error by default
and warns on -Wstrict-prototypes. It's free to fix -Wstrict-prototypes
while we're here and it futureproofs us, so throw that in.

The only notable part of this which might not be super obvious is
<stddef.h> for size_t.

See: 12078e7
Signed-off-by: Sam James <sam@gentoo.org>
@bedevere-bot bedevere-bot mentioned this issue Nov 12, 2022
Merged
thesamesam added a commit to thesamesam/cpython that referenced this issue Nov 12, 2022
@thesamesam
pythongh-99086: Further -Wstrict-prototypes, -Wimplicit-function-decl…
741df47 
…aration fixes

Followup to 12078e7. I ended up missing
a few, apparently.

Clang 16 makes -Wimplicit-function-declaration an error by default
and warns on -Wstrict-prototypes. It's free to fix -Wstrict-prototypes
while we're here and it futureproofs us, so throw that in.

The only notable part of this which might not be super obvious is
<stddef.h> for size_t.

See: 12078e7
Signed-off-by: Sam James <sam@gentoo.org>
thesamesam added a commit to thesamesam/cpython that referenced this issue Nov 12, 2022
@thesamesam
pythongh-99086: Further -Wstrict-prototypes, -Wimplicit-function-decl…
e7d69e1 
…aration fixes

Followup to 12078e7. I ended up missing
a few, apparently.

Clang 16 makes -Wimplicit-function-declaration an error by default
and warns on -Wstrict-prototypes. It's free to fix -Wstrict-prototypes
while we're here and it futureproofs us, so throw that in.

The only notable part of this which might not be super obvious is
<stddef.h> for size_t.

See: 12078e7
Signed-off-by: Sam James <sam@gentoo.org>
thesamesam added a commit to thesamesam/cpython that referenced this issue Nov 24, 2022
@thesamesam
pythongh-99086: Further -Wstrict-prototypes, -Wimplicit-function-decl…
0287ff9 
…aration fixes

Followup to 12078e7. I ended up missing
a few, apparently.

Clang 16 makes -Wimplicit-function-declaration an error by default
and warns on -Wstrict-prototypes. It's free to fix -Wstrict-prototypes
while we're here and it futureproofs us, so throw that in.

The only notable part of this which might not be super obvious is
<stddef.h> for size_t.

See: 12078e7
Signed-off-by: Sam James <sam@gentoo.org>
thesamesam added a commit to thesamesam/cpython that referenced this issue Nov 24, 2022
@thesamesam
pythongh-99086: Further -Wstrict-prototypes, -Wimplicit-function-decl…
0ee1b0c 
…aration fixes

Followup to 12078e7. I ended up missing
a few, apparently.

Clang 16 makes -Wimplicit-function-declaration an error by default
and warns on -Wstrict-prototypes. It's free to fix -Wstrict-prototypes
while we're here and it futureproofs us, so throw that in.

The only notable part of this which might not be super obvious is
<stddef.h> for size_t.

See: 12078e7
kumaraditya303 pushed a commit that referenced this issue Nov 26, 2022
@thesamesam
gh-99086: Fix -Wstrict-prototypes, -Wimplicit-function-declaration wa…
e35ca41 
…rnings in configure.ac (#99406)

Follow up to 12078e7.
thesamesam added a commit to thesamesam/cpython that referenced this issue Dec 1, 2022
@thesamesam
[3.11] pythongh-99086: Fix -Wstrict-prototypes, -Wimplicit-function-d…
f6faee9 
…eclaration warnings in configure.ac (pythonGH-99406)

Follow up to 12078e7.
(cherry picked from commit e35ca41)
thesamesam added a commit to thesamesam/cpython that referenced this issue Dec 1, 2022
@thesamesam
[3.11] pythongh-99086: Fix -Wstrict-prototypes, -Wimplicit-function-d…
e9f27cd 
…eclaration warnings in configure.ac (pythonGH-99406)

Follow up to 12078e7.
(cherry picked from commit e35ca41)

Co-authored-by: Sam James <sam@gentoo.org>
thesamesam added a commit to thesamesam/cpython that referenced this issue Dec 1, 2022
@thesamesam
[3.11] pythongh-99086: Fix -Wstrict-prototypes, -Wimplicit-function-d…
5fbd168 
…eclaration warnings in configure.ac (pythonGH-99406)

Follow up to 12078e7..
(cherry picked from commit e35ca41)

Co-authored-by: Sam James <sam@gentoo.org>
This was referenced Dec 1, 2022
Merged
Merged
miss-islington pushed a commit that referenced this issue Dec 1, 2022
@thesamesam
[3.11] gh-99086: Fix -Wstrict-prototypes, -Wimplicit-function-declara… (
88b754b 
GH-99919)

…tion warnings in configure.ac (GH-99406)

Follow up to 12078e7. (cherry picked from commit e35ca41)
kumaraditya303 pushed a commit that referenced this issue Dec 1, 2022
@thesamesam
[3.10] GH-99086: Fix -Wstrict-prototypes, -Wimplicit-function-declara… (
807b103 
#99920)

[3.10] gh-99086: Fix -Wstrict-prototypes, -Wimplicit-function-declaration warnings in configure.ac (GH-99406)

Follow up to 12078e7.
(cherry picked from commit e35ca41)

Co-authored-by: Sam James <sam@gentoo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.10 3.11 3.12 build The build process and cross-build type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@thesamesam @erlend-aasland @kumaraditya303