Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-99582: freeze zipimport into _bootstrap_python #99583

Merged
merged 3 commits into from Dec 10, 2022

Conversation

kkpattern
Copy link
Contributor

@kkpattern kkpattern commented Nov 18, 2022

When build python with other build systems, we may need _bootstrap_python to import modules from zipped stdlib.

I have tested this PR on Windows, Linux, and macOS. But since this change will affect the building process, I suggest we also test it with buildbot before merge.

@kumaraditya303 kumaraditya303 self-assigned this Nov 28, 2022
@kumaraditya303 kumaraditya303 added the build The build process and cross-build label Nov 28, 2022
Copy link
Contributor

@kumaraditya303 kumaraditya303 left a comment

LGTM

kkpattern and others added 2 commits Nov 28, 2022
When build python with other build systems, we may need
_bootstrap_python to import modules from zipped stdlib.
…e-99582.wvOBVy.rst

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
@kumaraditya303 kumaraditya303 added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 29, 2022
@bedevere-bot
Copy link

bedevere-bot commented Nov 29, 2022

🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit 1eda26d 🤖

If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 29, 2022
@kumaraditya303 kumaraditya303 merged commit 228c92e into python:main Dec 10, 2022
91 of 92 checks passed
@kumaraditya303
Copy link
Contributor

kumaraditya303 commented Dec 10, 2022

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build The build process and cross-build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants