New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(🎁) Add 3.12-dev to CI #14050

Merged

hauntsaninja merged 3 commits into python:master from KotlinIsland:3.12

Dec 14, 2022

Contributor

KotlinIsland commented Nov 9, 2022 •

edited

Adding a fail-able 3.12-dev job to the CI

KotlinIsland changed the title ~~Add 3.12-dev to CI~~ (🎁) Add 3.12-dev to CI

This comment has been minimized.

Sign in to view

1 similar comment

This comment has been minimized.

Sign in to view

Contributor Author

KotlinIsland commented Nov 10, 2022

Very strange, pytest seems to timeout github right near the end, I'll continue investigating when I have time.

This comment has been minimized.

Sign in to view

Member

JelleZijlstra commented Dec 8, 2022

Maybe make it skip the lxml install; it's probably not worth it to try to build from source, and we can still get useful data from tests that don't rely on XML reports.

Collaborator

hauntsaninja commented Dec 8, 2022

Yup, do the opposite of #14134

KotlinIsland force-pushed the 3.12 branch 2 times, most recently from d28e37c to c7666be Compare


          Add 3.12-dev to CI

10ae17d

This comment has been minimized.

Sign in to view

Collaborator

hauntsaninja commented Dec 8, 2022

Hmm, 40 minutes and counting. Doesn't bode well

KotlinIsland force-pushed the 3.12 branch from c7666be to a80f9f4 Compare

Contributor Author

KotlinIsland commented Dec 8, 2022

Yeah, there is some issue with the tests right at the end, I'm temporarily increasing pytest verbosity and rerunning.

This comment has been minimized.

Sign in to view

Contributor Author

KotlinIsland commented Dec 8, 2022

@JelleZijlstra @hauntsaninja If you see this before it times out (6 hours), could you cancel the current run so I can analyze the logs?

Member

JelleZijlstra commented Dec 8, 2022

done

Contributor Author

KotlinIsland commented Dec 8, 2022

It's mypyc/test/test_run.py::TestRun::run-functions.test::testDecorators1 that it's hanging on.

KotlinIsland force-pushed the 3.12 branch 2 times, most recently from 1e44f40 to 9d990e4 Compare

This comment has been minimized.

Sign in to view

KotlinIsland force-pushed the 3.12 branch 9 times, most recently from a9e77c3 to 01f2357 Compare

KotlinIsland force-pushed the 3.12 branch 13 times, most recently from e758e08 to e04816a Compare


          add test timeout

6f8bdbf

KotlinIsland force-pushed the 3.12 branch from e04816a to 6f8bdbf Compare

This comment has been minimized.

Sign in to view

AlexWaygood added the topic-tests label

Contributor Author

KotlinIsland commented Dec 12, 2022

@JelleZijlstra Wanna review this now?

hauntsaninja reviewed

mypyc/test/test_run.py Show resolved Hide resolved

hauntsaninja reviewed

mypyc/test/test_run.py Outdated Show resolved Hide resolved


          Update mypyc/test/test_run.py

14ceb00

hauntsaninja approved these changes

Collaborator

hauntsaninja left a comment

Okay, this seems fine to me. Let me know if you're interested in fixing any of the failing tests and need help

Contributor Author

KotlinIsland commented Dec 12, 2022

Okay, this seems fine to me. Let me know if you're interested in fixing any of the failing tests and need help

If I have time I can look into it, is this good to merge now?

Contributor

github-actions bot commented Dec 12, 2022

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

hauntsaninja merged commit d62be28 into python:master

18 checks passed

KotlinIsland deleted the 3.12 branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment