gh-57762: fix misleading tkinter.Tk docstring #98837
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mentioned as a desired change by terryjreedy on the corresponding issue, since Tk is not a subclass of Toplevel.
|
Thanks @hauntsaninja for the PR |
|
GH-100440 is a backport of this pull request to the 3.11 branch. |
|
GH-100441 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 22, 2022
Mentioned as a desired change by terryjreedy on the corresponding issue, since Tk is not a subclass of Toplevel. (cherry picked from commit ad23da0) Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 22, 2022
Mentioned as a desired change by terryjreedy on the corresponding issue, since Tk is not a subclass of Toplevel. (cherry picked from commit ad23da0) Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
miss-islington
added a commit
that referenced
this pull request
Dec 22, 2022
miss-islington
added a commit
that referenced
this pull request
Dec 22, 2022
|
Thank you. I somehow missed or maybe just glided over the the review request. I just verified that my comment was correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Mentioned as a desired change by terryjreedy on the corresponding issue, since Tk is not a subclass of Toplevel.