Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document that zipfile's pwd parameter is a bytes object #100209

Merged
merged 1 commit into from Dec 16, 2022
Merged

Document that zipfile's pwd parameter is a bytes object #100209

merged 1 commit into from Dec 16, 2022
+8 −7

Conversation

JustAnotherArchivist
Copy link
Contributor

@JustAnotherArchivist JustAnotherArchivist commented Dec 13, 2022

Trivial docs change for which no issue exists.

This has been a requirement for a very long time (the exception on using non-bytes was added before 2.7; I didn't search beyond that) but was never documented anywhere as far as I can see.

Needs backports to earlier branches.

@netlify
Copy link

netlify bot commented Dec 13, 2022 •
edited

✅ Deploy Preview for python-cpython-preview ready!

Name Link
🔨 Latest commit 81b6e1a
🔍 Latest deploy log https://app.netlify.com/sites/python-cpython-preview/deploys/6398236f8640a20009af66fd
😎 Deploy Preview https://deploy-preview-100209--python-cpython-preview.netlify.app/library/zipfile
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news labels Dec 13, 2022
hauntsaninja
hauntsaninja approved these changes Dec 13, 2022
View changes
Copy link
Contributor

@hauntsaninja hauntsaninja left a comment

Thanks, this looks good to me. I confirmed that pwd does seem to need to be bytes and not e.g. bytearray or a buffer.

Doc/library/zipfile.rst Outdated Show resolved Hide resolved
kumaraditya303
kumaraditya303 approved these changes Dec 16, 2022
View changes
Copy link
Contributor

@kumaraditya303 kumaraditya303 left a comment

It is checked here:

cpython/Lib/zipfile/__init__.py

Lines 1491 to 1498 in e00266f

def setpassword(self, pwd):
"""Set default password for encrypted files."""
if pwd and not isinstance(pwd, bytes):
raise TypeError("pwd: expected bytes, got %s" % type(pwd).__name__)
if pwd:
self.pwd = pwd
else:
self.pwd = None

LGTM thanks!

@kumaraditya303 kumaraditya303 merged commit 5ee7eb9 into python:main Dec 16, 2022
21 checks passed
carljm added a commit to carljm/cpython that referenced this pull request Dec 16, 2022
@carljm
Merge branch 'main' into fastmock
2260a54 
* main:
  Improve stats presentation for calls. (pythonGH-100274)
  Better stats for `LOAD_ATTR` and `STORE_ATTR` (pythonGH-100295)
  pythongh-81057: Move the Cached Parser Dummy Name to _PyRuntimeState (python#100277)
  Document that zipfile's pwd parameter is a `bytes` object (python#100209)
  pythongh-99767: mark `PyTypeObject.tp_watched` as internal use only in table (python#100271)
  Fix typo in introduction.rst (python#100266)
  pythongh-78997: AttributeError if loading fails in LibraryLoader.__getattr__
  pythonGH-100234: Set a default value for random.expovariate() (pythonGH-100235)
  Remove uninformative itertools recipe (pythonGH-100253)
  pythonGH-99767: update PyTypeObject docs for type watchers (pythonGH-99928)
  Move stats for the method cache into the `Py_STAT` machinery (pythonGH-100255)
  pythonGH-100222: fix typo _py_set_opocde -> _py_set_opcode (pythonGH-100259)
  pythonGH-100000: Cleanup and polish various watchers code (pythonGH-99998)
  pythongh-90111: Minor Cleanup for Runtime-Global Objects (pythongh-100254)
@JustAnotherArchivist
Copy link
Contributor Author

JustAnotherArchivist commented Dec 16, 2022 •
edited

@kumaraditya303 Thanks for merging! How about backporting it to the other branches (at least the supported ones)? I think this needs some 'needs backport to X' labels.

@miss-islington
Copy link
Contributor

miss-islington commented Dec 17, 2022

Thanks @JustAnotherArchivist for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Dec 17, 2022

Thanks @JustAnotherArchivist for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Dec 17, 2022

GH-100309 is a backport of this pull request to the 3.11 branch.

@bedevere-bot
Copy link

bedevere-bot commented Dec 17, 2022

GH-100310 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 17, 2022
@JustAnotherArchivist @miss-islington
Document that zipfile's pwd parameter is a bytes object (pythonGH-1…
bd330a4 
…00209)

(cherry picked from commit 5ee7eb9)

Co-authored-by: JustAnotherArchivist <JustAnotherArchivist@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 17, 2022
@JustAnotherArchivist @miss-islington
Document that zipfile's pwd parameter is a bytes object (pythonGH-1…
6c5e97a 
…00209)

(cherry picked from commit 5ee7eb9)

Co-authored-by: JustAnotherArchivist <JustAnotherArchivist@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Dec 17, 2022
@miss-islington @JustAnotherArchivist
Document that zipfile's pwd parameter is a bytes object (GH-100209)
697a07a 
(cherry picked from commit 5ee7eb9)

Co-authored-by: JustAnotherArchivist <JustAnotherArchivist@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Dec 17, 2022
@miss-islington @JustAnotherArchivist
Document that zipfile's pwd parameter is a bytes object (GH-100209)
e3d8578 
(cherry picked from commit 5ee7eb9)

Co-authored-by: JustAnotherArchivist <JustAnotherArchivist@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hauntsaninja hauntsaninja

@kumaraditya303 kumaraditya303

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@JustAnotherArchivist @miss-islington @bedevere-bot @hauntsaninja @kumaraditya303