gh-93649: Split unicode tests from _testcapimodule.c & add some more #95819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
encukou
added
skip news
bedevere-bot
removed
the
This was referenced Aug 10, 2022
iritkatriel
pushed a commit
to iritkatriel/cpython
that referenced
this issue
Aug 11, 2022
… more (pythonGH-95819) - Move PyUnicode tests to a separate file - Add some more tests for PyUnicode_FromFormat Co-authored-by: philg314 <110174000+philg314@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This is the refactoring & tests for existing functionality from #95505, leaving the change (and its tests) for another PR.
In addition to the changes in #95505, I made
CHECK_FORMAT_*to check for SystemError when it gets NULL as the expected result. Some tests need that, as the behavior changed in #95784.