gh-91447: Fix findtext to only give an empty string on None #91486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The API documentation for it states that this function gives back an empty string on "no text content." With the previous implementation, this would give back an emtpy string even on text content values such as 0 or False. This attempts to resolve that by only giving back an empty string if the text attribute is set to None.
|
@serhiy-storchaka This is in reference to line 419 and line 422? |
|
Are you also referring to line 2742 and line 2751? |
gvanrossum
approved these changes
Aug 1, 2022
gvanrossum
reviewed
Aug 1, 2022
gvanrossum
added
the
|
Status check is done, and it's a success |
|
@pablogsal Do you recommend backporting this to 3.11? It's been like that forever, so it doesn't strike me as urgent. If not to 3.11, would it go into 3.11.1 or stay in 3.12? |
Thanks for checking with me! Yeah, I think is ok to backport to 3.11 given that is a small fix that's fixing an existing bug. But please, let's do it before rc1 :) |
|
Thanks @eugenetriguba for the PR |
|
GH-95543 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 1, 2022
…thonGH-91486) The API documentation for [findtext](https://docs.python.org/3/library/xml.etree.elementtree.htmlGH-xml.etree.ElementTree.Element.findtext) states that this function gives back an empty string on "no text content." With the previous implementation, this would give back a empty string even on text content values such as 0 or False. This patch attempts to resolve that by only giving back an empty string if the text attribute is set to `None`. Resolves pythonGH-91447. Automerge-Triggered-By: GH:gvanrossum (cherry picked from commit a95e60d) Co-authored-by: Eugene Triguba <eugenetriguba@gmail.com>
miss-islington
added a commit
that referenced
this pull request
Aug 1, 2022
The API documentation for [findtext](https://docs.python.org/3/library/xml.etree.elementtree.htmlGH-xml.etree.ElementTree.Element.findtext) states that this function gives back an empty string on "no text content." With the previous implementation, this would give back a empty string even on text content values such as 0 or False. This patch attempts to resolve that by only giving back an empty string if the text attribute is set to `None`. Resolves GH-91447. Automerge-Triggered-By: GH:gvanrossum (cherry picked from commit a95e60d) Co-authored-by: Eugene Triguba <eugenetriguba@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The API documentation for findtext states that this function gives back an empty string on "no text content." With the previous implementation, this would give back a empty string even on text content values such as 0 or False. This patch attempts to resolve that by only giving back an empty string if the text attribute is set to
None. Resolves #91447.Automerge-Triggered-By: GH:gvanrossum