Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-27513: email.utils.getaddresses() now handles Header objects #13797

Merged
merged 2 commits into from Jul 19, 2021
+9 −1
Merged

bpo-27513: email.utils.getaddresses() now handles Header objects #13797

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf600e1
bpo-27513: email.utils.getaddresses() now handles Header objects
ZackerySpytz Jun 4, 2019
1c79276
Respond to review
ambv Jul 19, 2021
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 Lib/email/utils.py
View file
Open in desktop
@@ -109,7 +109,7 @@ def formataddr(pair, charset='utf-8'):

def getaddresses(fieldvalues):
"""Return a list of (REALNAME, EMAIL) for each fieldvalue."""
all = COMMASPACE.join(fieldvalues)
all = COMMASPACE.join(str(v) for v in fieldvalues)
a = _AddressList(all)
return a.addresslist

5 Lib/test/test_email/test_email.py
View file
Open in desktop
@@ -3263,6 +3263,11 @@ def test_getaddresses_embedded_comment(self):
addrs = utils.getaddresses(['User ((nested comment)) <foo@bar.com>'])
eq(addrs[0][1], 'foo@bar.com')

def test_getaddresses_header_obj(self):
"""Test the handling of a Header object."""
addrs = utils.getaddresses([Header('Al Person <aperson@dom.ain>')])
self.assertEqual(addrs[0][1], 'aperson@dom.ain')

def test_make_msgid_collisions(self):
# Test make_msgid uniqueness, even with multiple threads
class MsgidsThread(Thread):
3 Misc/NEWS.d/next/Library/2019-06-03-23-53-25.bpo-27513.qITN7d.rst
View file
Open in desktop
@@ -0,0 +1,3 @@
:func:`email.utils.getaddresses` now accepts
:class:`email.header.Header` objects along with string values.
Patch by Zackery Spytz.