Class HTMLParser may not be initialized properly as method ParserBase.init is not called from its init method #95813

MyreMylar · 2022-08-09T07:50:49Z

Bug report

Hello,

I receive the error in the title from LGTM.com when subclassing the HTMLParser class. Should HTMLParser technically be calling: super().__init__(), or something similar, in its own initialiser? I know adding this call won't improve the functionality as the BaseParser initialiser does nothing of interest for subclasses, but I guess it would stop annoying errors like this.

Relevant code is here:

cpython/Lib/html/parser.py

Lines 62 to 93 in eb81c1a

    
           class HTMLParser(_markupbase.ParserBase): 
        
               """Find tags and other markup and call handler functions. 
        
               Usage: 
        
                   p = HTMLParser() 
        
                   p.feed(data) 
        
                   ... 
        
                   p.close() 
        
               Start tags are handled by calling self.handle_starttag() or 
        
               self.handle_startendtag(); end tags by self.handle_endtag().  The 
        
               data between tags is passed from the parser to the derived class 
        
               by calling self.handle_data() with the data as argument (the data 
        
               may be split up in arbitrary chunks).  If convert_charrefs is 
        
               True the character references are converted automatically to the 
        
               corresponding Unicode character (and self.handle_data() is no 
        
               longer split in chunks), otherwise they are passed by calling 
        
               self.handle_entityref() or self.handle_charref() with the string 
        
               containing respectively the named or numeric reference as the 
        
               argument. 
        
               """ 
        
               CDATA_CONTENT_ELEMENTS = ("script", "style") 
        
               def __init__(self, *, convert_charrefs=True): 
        
                   """Initialize and reset this instance. 
        
                   If convert_charrefs is True (the default), all character references 
        
                   are automatically converted to the corresponding Unicode characters. 
        
                   """ 
        
                   self.convert_charrefs = convert_charrefs 
        
                   self.reset()

And here:

cpython/Lib/_markupbase.py

Lines 23 to 30 in eb81c1a

    
           class ParserBase: 
        
               """Parser base class which provides some common support methods used 
        
               by the SGML/HTML and XHTML parsers.""" 
        
               def __init__(self): 
        
                   if self.__class__ is ParserBase: 
        
                       raise RuntimeError( 
        
                           "_markupbase.ParserBase must be subclassed")

The text was updated successfully, but these errors were encountered:

* gh-95813: Improve HTMLParser from the view of inheritance * gh-95813: Add unittest * Address code review

…on#95874) * pythongh-95813: Improve HTMLParser from the view of inheritance * pythongh-95813: Add unittest * Address code review

MyreMylar added the type-bug An unexpected behavior, bug, or error label Aug 9, 2022

corona10 added a commit to corona10/cpython that referenced this issue Aug 11, 2022

pythongh-95813: Improve HTMLParser from the view of inheritance

cd3160d

bedevere-bot mentioned this issue Aug 11, 2022

gh-95813: Improve HTMLParser from the view of inheritance #95874

Merged

ezio-melotti self-assigned this Aug 11, 2022

corona10 added a commit to corona10/cpython that referenced this issue Aug 11, 2022

pythongh-95813: Add unittest

b9c4bb3

corona10 added a commit to corona10/cpython that referenced this issue Aug 17, 2022

pythongh-95813: Improve HTMLParser from the view of inheritance

774ab32

corona10 added a commit to corona10/cpython that referenced this issue Aug 17, 2022

pythongh-95813: Add unittest

86c1fe4

ezio-melotti linked a pull request Aug 18, 2022 that will close this issue

gh-95813: Improve HTMLParser from the view of inheritance #95874

Merged

ezio-melotti closed this as completed in #95874 Aug 18, 2022

ezio-melotti pushed a commit that referenced this issue Aug 18, 2022

gh-95813: Improve HTMLParser from the view of inheritance (#95874)

157aef7

* gh-95813: Improve HTMLParser from the view of inheritance * gh-95813: Add unittest * Address code review

tiran pushed a commit to tiran/cpython that referenced this issue Aug 19, 2022

pythongh-95813: Improve HTMLParser from the view of inheritance (pyth…

12af353

…on#95874) * pythongh-95813: Improve HTMLParser from the view of inheritance * pythongh-95813: Add unittest * Address code review

Class HTMLParser may not be initialized properly as method ParserBase.__init__ is not called from its __init__ method #95813

Class HTMLParser may not be initialized properly as method ParserBase.__init__ is not called from its __init__ method #95813

Comments

MyreMylar commented Aug 9, 2022

Bug report

Class HTMLParser may not be initialized properly as method ParserBase.init is not called from its init method #95813

Class HTMLParser may not be initialized properly as method ParserBase.init is not called from its init method #95813