Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-90699: Remove _Py_IDENTIFIER usage from _asyncio module #99010

Merged
merged 1 commit into from Nov 2, 2022

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Nov 2, 2022

Automerge-Triggered-By: GH:ericsnowcurrently

Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

LGTM

@ericsnowcurrently ericsnowcurrently added the 🤖 automerge PR will be merged once it's been approved and all CI passed label Nov 2, 2022
@JelleZijlstra JelleZijlstra merged commit 18fc232 into python:main Nov 2, 2022
13 checks passed
@kumaraditya303 kumaraditya303 deleted the asyncio branch Nov 2, 2022
Copy link
Member

@gvanrossum gvanrossum left a comment

Interesting. I guess this makes it easier to convert this code to two-phase init?

@ericsnowcurrently
Copy link
Member

ericsnowcurrently commented Nov 2, 2022

Yep. Also, we're trying to get rid of _Py_IDENTIFIER().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 automerge PR will be merged once it's been approved and all CI passed skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants