Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unsupported SRE opcode CALL #91870

Closed
serhiy-storchaka opened this issue Apr 24, 2022 · 0 comments · Fixed by #91872
Closed

Remove unsupported SRE opcode CALL #91870

serhiy-storchaka opened this issue Apr 24, 2022 · 0 comments · Fixed by #91872
Labels
expert-regex type-feature A feature request or enhancement

Comments

@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Apr 24, 2022

It seems that SRE initially kind of supported atomic groups. At least it was supported in the compiler and in the interpreter, but not in the parser. And opcode CALL was added for this. In 43b3b49 the support of opcode CALL was removed from the interpreter, but it was left in the compiler.

A new opcode ATOMIC_GROUP was added to support atomic groups, so now we can remove opcode CALL.

Alternatively we can rename ATOMIC_GROUP to CALL.

@serhiy-storchaka serhiy-storchaka added type-feature A feature request or enhancement expert-regex labels Apr 24, 2022
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue Apr 24, 2022
It was initially added to support atomic groups, but that
support was never fully implemented, and CALL was only left
in the compiler, but not interpreter and parser.

ATOMIC_GROUP is now used to support atomic groups.
serhiy-storchaka added a commit that referenced this issue Apr 26, 2022
It was initially added to support atomic groups, but that
support was never fully implemented, and CALL was only left
in the compiler, but not interpreter and parser.

ATOMIC_GROUP is now used to support atomic groups.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
expert-regex type-feature A feature request or enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant