Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-93975: Nicer error reporting in test_venv #93959

Merged
merged 1 commit into from Jun 18, 2022
Merged

gh-93975: Nicer error reporting in test_venv #93959

merged 1 commit into from Jun 18, 2022
+32 −14

Conversation

jaraco
Copy link
Member

@jaraco jaraco commented Jun 17, 2022 •
edited by miss-islington

  • gh-93957: Provide nicer error reporting from subprocesses in test_venv.EnsurePipTest.test_with_pip.
  • Update changelog

This change does three things:

  1. Extract a function for trapping output in subprocesses.
  2. Emit both stdout and stderr when encountering an error.
  3. Apply the change to ensurepip._uninstall check.

Automerge-Triggered-By: GH:jaraco

@jaraco jaraco requested a review from vsajip as a code owner Jun 17, 2022
@bedevere-bot bedevere-bot added tests awaiting core review labels Jun 17, 2022
@jaraco jaraco changed the title Nicer error reporting in test_venv gh-93975: Nicer error reporting in test_venv Jun 17, 2022
vsajip
vsajip approved these changes Jun 18, 2022
View changes
@jaraco jaraco added the 🤖 automerge label Jun 18, 2022
@miss-islington miss-islington merged commit 6066f45 into main Jun 18, 2022
14 checks passed
@miss-islington miss-islington deleted the gh-93957/nicer-error branch Jun 18, 2022
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jun 18, 2022

Thanks @jaraco for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10, 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jun 18, 2022

Sorry @jaraco, I had trouble checking out the 3.11 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 6066f450b91f1cbebf33a245c14e660052ccd90a 3.11

@miss-islington miss-islington self-assigned this Jun 18, 2022
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jun 18, 2022

Sorry, @jaraco, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 6066f450b91f1cbebf33a245c14e660052ccd90a 3.10

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jun 18, 2022

Sorry @jaraco, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 6066f450b91f1cbebf33a245c14e660052ccd90a 3.9

jaraco added a commit that referenced this issue Jun 19, 2022
@jaraco
[3.11] gh-93975: Nicer error reporting in test_venv (GH-93959)
ff79876 
- gh-93957: Provide nicer error reporting from subprocesses in test_venv.EnsurePipTest.test_with_pip.
- Update changelog

This change does three things:

1. Extract a function for trapping output in subprocesses.
2. Emit both stdout and stderr when encountering an error.
3. Apply the change to `ensurepip._uninstall` check.
(cherry picked from commit 6066f45)

Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jun 19, 2022

GH-94003 is a backport of this pull request to the 3.11 branch.

jaraco added a commit that referenced this issue Jun 19, 2022
@jaraco
[3.10] gh-93975: Nicer error reporting in test_venv (GH-93959)
dd4016e 
- gh-93957: Provide nicer error reporting from subprocesses in test_venv.EnsurePipTest.test_with_pip.
- Update changelog

This change does three things:

1. Extract a function for trapping output in subprocesses.
2. Emit both stdout and stderr when encountering an error.
3. Apply the change to `ensurepip._uninstall` check..
(cherry picked from commit 6066f45)

Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jun 19, 2022

GH-94004 is a backport of this pull request to the 3.10 branch.

jaraco added a commit that referenced this issue Jun 19, 2022
@jaraco
[3.9] gh-93975: Nicer error reporting in test_venv (GH-93959)
3f5b7ac 
- gh-93957: Provide nicer error reporting from subprocesses in test_venv.EnsurePipTest.test_with_pip.
- Update changelog

This change does three things:

1. Extract a function for trapping output in subprocesses.
2. Emit both stdout and stderr when encountering an error.
3. Apply the change to `ensurepip._uninstall` check..
(cherry picked from commit 6066f45)

Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jun 19, 2022

GH-94005 is a backport of this pull request to the 3.9 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsajip vsajip

Assignees

@miss-islington miss-islington

Labels
🤖 automerge tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jaraco @miss-islington @bedevere-bot @vsajip