Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-100117: Make co_lines more efficient #100447

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

GH-100117: Make co_lines more efficient #100447

wants to merge 3 commits into from
+26 −38

Conversation

brandtbucher
Copy link
Member

@brandtbucher brandtbucher commented Dec 23, 2022 •
edited by bedevere-bot

Basically, this just merges all of the entries for a given line range into a single tuple. This can have a dramatic effect on the size of the resulting iterator:

Before:

>>> from dis import dis as example
>>> lines = list(example.__code__.co_lines())
>>> len(lines)
148

After:

>>> from dis import dis as example
>>> lines = list(example.__code__.co_lines())
>>> len(lines)
39

@brandtbucher brandtbucher added the interpreter-core (Objects, Python, Grammar, and Parser dirs) label Dec 23, 2022
@brandtbucher brandtbucher self-assigned this Dec 23, 2022
@brandtbucher brandtbucher requested a review from markshannon as a code owner Dec 23, 2022
@bedevere-bot bedevere-bot mentioned this pull request Dec 23, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markshannon markshannon

Assignees

@brandtbucher brandtbucher

Labels
awaiting core review interpreter-core (Objects, Python, Grammar, and Parser dirs)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brandtbucher @bedevere-bot