[3.7] bpo-28866: No type cache for types with specialized mro, invalidation is hard. (GH-13157) #13589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is hard. (pythonGH-13157) * No type cache for types with specialized mro, invalidation is hard. * FIX: Don't disable method cache custom types that do not implement mro(). * fixing implem. * Avoid storing error flags, also decref. * news entry * Clear as soon as we're getting an error. * FIX: Reference leak. (cherry picked from commit 180dc1b) Co-authored-by: Julien Palard <julien@palard.fr>
|
@JulienPalard and @markshannon: Status check is done, and it's a success |
JulienPalard
added
the
JulienPalard
approved these changes
May 26, 2019
|
@JulienPalard and @markshannon: Status check is done, and it's a success |
astrofrog
added a commit
to astrofrog/glue
that referenced
this pull request
Aug 11, 2019
…tsByName. The error happens following the change in python/cpython#13589. Basically it looks like connectSlotsByName causes all properties of the Qt class to be accessed, but the viewer property didn't previously work before the load_ui call since _viewer wasn't defined and an AttributeError was raised. The fix here is to make sure that self._viewer is defined before load_ui is called.
astrofrog
added a commit
to glue-viz/glue
that referenced
this pull request
Aug 12, 2019
…tsByName. The error happens following the change in python/cpython#13589. Basically it looks like connectSlotsByName causes all properties of the Qt class to be accessed, but the viewer property didn't previously work before the load_ui call since _viewer wasn't defined and an AttributeError was raised. The fix here is to make sure that self._viewer is defined before load_ui is called.
astrofrog
added a commit
to glue-viz/glue
that referenced
this pull request
Aug 13, 2019
…tsByName. The error happens following the change in python/cpython#13589. Basically it looks like connectSlotsByName causes all properties of the Qt class to be accessed, but the viewer property didn't previously work before the load_ui call since _viewer wasn't defined and an AttributeError was raised. The fix here is to make sure that self._viewer is defined before load_ui is called.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
No type cache for types with specialized mro, invalidation is hard.
FIX: Don't disable method cache custom types that do not implement mro().
fixing implem.
Avoid storing error flags, also decref.
news entry
Clear as soon as we're getting an error.
FIX: Reference leak.
(cherry picked from commit 180dc1b)
Co-authored-by: Julien Palard julien@palard.fr
https://bugs.python.org/issue28866