Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Use PY_VERSION_HEX for version comparison #100179

Merged
merged 2 commits into from Dec 17, 2022
Merged

Docs: Use PY_VERSION_HEX for version comparison #100179

merged 2 commits into from Dec 17, 2022

Commits on Dec 11, 2022

  1. Use PY_VERSION_HEX for version comparison 

    `PY_VERSION_HEX` should be used when comparing version numbers, for
example `PY_VERSION_HEX >= 0x03080000`.

Avoid `PY_MAJOR_VERSION >= 3 && PY_MINOR_VERSION >= 8` because
that is true for 3.8-3.12, but also for 4.8-4.12 and so on.

Hoist the comment from `PY_VERSION_HEX`'s definition in `patchlevel.h`
to docs in `apiabiversion.rst`.
    @hugovk
    hugovk committed Dec 11, 2022
    02a0eb0

Commits on Dec 12, 2022

  1. Add full stop 

    Co-authored-by: Stanley <46876382+slateny@users.noreply.github.com>
    @hugovk @slateny
    hugovk and slateny committed Dec 12, 2022
    52763bb