Update URLs in comments and metadata to use HTTPS #27458

coderanger · 2021-07-29T19:21:48Z

Update four to current locations.
Initially reported by Raphael raphaelvowles@yahoo.co.uk via webmaster@python for the metadata.

…ew to newer locations to fight linkrot.

the-knights-who-say-ni · 2021-07-29T19:21:50Z

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@coderanger

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

terryjreedy

I would not normally review until CLA signed, but this is equivalent to typo fixes.
Please note when you sign. It usually takes a working day or two to get recorded.

Did you change all URLs or skip some after testing?

terryjreedy · 2021-07-29T20:49:22Z

Doc/conf.py

@@ -85,7 +85,7 @@

 # Custom sidebar templates, filenames relative to this file.
 html_sidebars = {
-    # Defaults taken from http://www.sphinx-doc.org/en/stable/config.html#confval-html_sidebars
+    # Defaults taken from https://www.sphinx-doc.org/en/master/usage/configuration.html#confval-html_sidebars


The old url is forwarded to this.

terryjreedy · 2021-07-29T20:49:22Z

Mac/README.rst

@@ -399,8 +399,8 @@ The basic implementation pattern is:
 Resources
 =========

-  *  http://www.python.org/download/mac/
+  *  https://www.python.org/downloads/mac-osx/


Old URL forwards to this.

Please don't change this occurence as "mac-osx" is an outdated term. We should rather fix the website to use the modern "macOS" term instead.

I think that's best left to a later discussion, this reflects the current state of the world :)

The current state of the world is that the redirect works and we don't need to modify the line in the README. If we do, we'll have to change the README again.

(if you only want to s/http/https/ then that's obviously fine)

Yes? Changing it again will be correct, unless you want me to just go change the website now, which I can also do :) Relying on redirects leads to rot and should be avoided.

https://github.com/python/pythondotorg/blob/7556542b58d9c90717757c9fa997637752d6dd85/pydotorg/urls.py#L30 is what's performing the current redirect, but changing this will have deeper impact on a number of views. I understand your point that mac-osx is an out of date reference but it's the correct one for python.org.

I changed the DB entry on python.org. The URL is now:
https://www.python.org/downloads/macos/

Unfortunately, as you noted, some things are needlessly static in the source code. I created this PR to update it:
python/pythondotorg#1829

terryjreedy · 2021-07-29T20:49:22Z

setup.py

@@ -1237,7 +1237,7 @@ def detect_dbm_gdbm(self):
        # similar functionality (but slower of course) implemented in Python.

        # Sleepycat^WOracle Berkeley DB interface.
-        #  http://www.oracle.com/database/berkeley-db/db/index.html
+        #  https://www.oracle.com/database/technologies/related/berkeleydb.html


Old URL forwards to this.

terryjreedy · 2021-07-29T20:49:22Z

setup.py

@@ -1279,7 +1279,7 @@ def gen_db_minor_ver_nums(major):
            '/usr/include/db3',
            '/usr/local/include/db3',
            '/opt/sfw/include/db3',
-            # Fink defaults (http://fink.sourceforge.net/)
+            # Fink defaults (https://www.finkproject.org/)


Old url flakey; if it works, gets forwarded to new page, which was updated yesterday.

coderanger · 2021-07-29T20:50:50Z

I was mostly targeting rg 'http://(www\.)?python\.org' -g '!Lib/test/**' but fixed a few others in the same files while I was there.

miss-islington · 2021-07-30T13:54:49Z

Thanks @coderanger for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖

bedevere-bot · 2021-07-30T13:54:56Z

GH-27478 is a backport of this pull request to the 3.10 branch.

miss-islington · 2021-07-30T13:54:57Z

Sorry, @coderanger and @ambv, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker be42c06bb01206209430f3ac08b72643dc7cad1c 3.9

(cherry picked from commit be42c06) Co-authored-by: Noah Kantrowitz <noah@coderanger.net>

…). (cherry picked from commit be42c06) Co-authored-by: Noah Kantrowitz <noah@coderanger.net>

bedevere-bot · 2021-07-30T14:01:14Z

GH-27480 is a backport of this pull request to the 3.9 branch.

(cherry picked from commit be42c06) Co-authored-by: Noah Kantrowitz <noah@coderanger.net>

…H-27480) (cherry picked from commit be42c06) Co-authored-by: Noah Kantrowitz <noah@coderanger.net>

Update many URLs in comments and metadata to use HTTPS and update a f…

ce21a9b

…ew to newer locations to fight linkrot.

coderanger requested review from 1st1, lysnikolaou, pablogsal, rhettinger, terryjreedy and a team as code owners Jul 29, 2021

bedevere-bot added the awaiting review label Jul 29, 2021

the-knights-who-say-ni added the CLA not signed label Jul 29, 2021

terryjreedy changed the title ~~Update many URLs in comments and metadata to use HTTPS and update a few to newer locations to fight linkrot~~ Update URLs in comments and metadata to use HTTPS and update a few to newer locations to fight linkrot Jul 29, 2021

terryjreedy changed the title ~~Update URLs in comments and metadata to use HTTPS and update a few to newer locations to fight linkrot~~ Update URLs in comments and metadata to use HTTPS Jul 29, 2021

the-knights-who-say-ni removed the CLA not signed label Jul 29, 2021

Update a test.

57d91c9

terryjreedy approved these changes Jul 29, 2021

View changes

terryjreedy added needs backport to 3.9 needs backport to 3.10 labels Jul 29, 2021

the-knights-who-say-ni added the CLA signed label Jul 29, 2021

bedevere-bot added awaiting merge and removed awaiting review labels Jul 29, 2021

Update macOS link to match python/pythondotorg#1829

2f2a9e5

ambv added skip issue skip news labels Jul 30, 2021

ambv merged commit be42c06 into main Jul 30, 2021
15 checks passed

ambv deleted the https-links branch Jul 30, 2021

bedevere-bot removed the awaiting merge label Jul 30, 2021

bedevere-bot removed the needs backport to 3.10 label Jul 30, 2021

miss-islington assigned ambv Jul 30, 2021

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 30, 2021

Update URLs in comments and metadata to use HTTPS (pythonGH-27458)

1f15eea

(cherry picked from commit be42c06) Co-authored-by: Noah Kantrowitz <noah@coderanger.net>

ambv pushed a commit to ambv/cpython that referenced this pull request Jul 30, 2021

[3.9] Update URLs in comments and metadata to use HTTPS (pythonGH-27458…

5f5de15

…). (cherry picked from commit be42c06) Co-authored-by: Noah Kantrowitz <noah@coderanger.net>

bedevere-bot removed the needs backport to 3.9 label Jul 30, 2021

ambv pushed a commit that referenced this pull request Jul 30, 2021

Update URLs in comments and metadata to use HTTPS (GH-27458) (GH-27478)

f7f1c26

(cherry picked from commit be42c06) Co-authored-by: Noah Kantrowitz <noah@coderanger.net>

ambv added a commit that referenced this pull request Jul 30, 2021

[3.9] Update URLs in comments and metadata to use HTTPS (GH-27458) (G…

168879e

…H-27480) (cherry picked from commit be42c06) Co-authored-by: Noah Kantrowitz <noah@coderanger.net>

adang1345 mentioned this pull request Sep 9, 2022

Official Windows installers are not interoperable with those built locally with Tools\msi\buildrelease.bat #96729

Closed

Update URLs in comments and metadata to use HTTPS #27458

Update URLs in comments and metadata to use HTTPS #27458

coderanger commented Jul 29, 2021 •

edited by terryjreedy

the-knights-who-say-ni commented Jul 29, 2021

terryjreedy left a comment

terryjreedy Jul 29, 2021

terryjreedy Jul 29, 2021

ambv Jul 29, 2021

coderanger Jul 29, 2021

ambv Jul 29, 2021

ambv Jul 29, 2021

coderanger Jul 29, 2021 •

edited

coderanger Jul 29, 2021

ambv Jul 29, 2021

terryjreedy Jul 29, 2021

terryjreedy Jul 29, 2021

coderanger commented Jul 29, 2021

miss-islington commented Jul 30, 2021

bedevere-bot commented Jul 30, 2021

miss-islington commented Jul 30, 2021

bedevere-bot commented Jul 30, 2021

Update URLs in comments and metadata to use HTTPS #27458

Update URLs in comments and metadata to use HTTPS #27458

Conversation

coderanger commented Jul 29, 2021 • edited by terryjreedy

the-knights-who-say-ni commented Jul 29, 2021

Recognized GitHub username

terryjreedy left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coderanger Jul 29, 2021 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coderanger commented Jul 29, 2021

miss-islington commented Jul 30, 2021

bedevere-bot commented Jul 30, 2021

miss-islington commented Jul 30, 2021

bedevere-bot commented Jul 30, 2021

coderanger commented Jul 29, 2021 •

edited by terryjreedy

coderanger Jul 29, 2021 •

edited