gh-100340: Allows -Wno-int-conversion for wasm #100341
Open
+45
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I looked at the output for https://buildbot.python.org/all/#/builders/1046 , but I couldn't find any way to tell what version of the WASI SDK was used to build Python. I know that @tiran set up the buildbots using https://github.com/tiran/ansible-wasm-buildbot . |
@brettcannon The buildbot is using version 16 according to https://github.com/tiran/ansible-wasm-buildbot/blob/main/roles/wasi-sdk/defaults/main.yml#L3 |
brettcannon
reviewed
Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Adds new configuration directive to disable
int-conversionand then using it for thewasm32-wasibuild only. This allows us to build on the version 17 of the wasm-sdk.How to test manually?
Install the version 17 of the SDK and then run the following command: