[3.11] gh-100160: Remove any deprecation warnings in asyncio.get_event_loop() #100412
+15
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_loop() They are deferred to Python 3.12.
gvanrossum
changed the title
gvanrossum
changed the title
gvanrossum
reviewed
Dec 21, 2022
Doc/library/asyncio-eventloop.rst
Outdated
| .. deprecated:: 3.10 | ||
| Deprecation warning is emitted if there is no current event loop. | ||
| In Python 3.12 it will be an error. | ||
|
|
||
| .. note:: | ||
| In Python versions 3.10.0--3.10.8 and 3.11.0 this function | ||
| (and other functions which used it implicitly) emitted a | ||
| :exc:`DeprecationWarning` if there was no running event loop, even if | ||
| the current loop was set. | ||
|
|
There was a problem hiding this comment.
Given the stormy history of deprecations here, maybe add a note indicating which versions emit deprecation warnings under which circumstances? I think it might be:
- 3.10.0-3.10.8, 3.11.0: warn if there is no running event loop
- 3.10.9, 3.11.1: warn if there's no running AND no current event loop
- 3.10.10+, 3.11.2+: no warning, may create new loop OR raise RuntimeError if there's no running and no current loop
- 3.12, 3.13: warning if it creates a new loop
- 3.14: error instead of creating a new loop
(Am I right about all that?)
Also in the next file.
|
Thank you for your review Guido. I switched it to draft to be sure that it will not be accidentally merged. The hard part in these PRs (#100410 and #100412) is documentation. It is difficult to find good place where all this mess should be documented, and I am bad in writing English. I think that non-documentation part is ready, but I am not sure about the documentation. Fill free to commit directly to this branch or create a new PR based on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
They are deferred to Python 3.12.