Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-81057: Move OS-Related Globals to _PyRuntimeState #100082

Merged
merged 6 commits into from Dec 8, 2022
Merged

gh-81057: Move OS-Related Globals to _PyRuntimeState #100082

merged 6 commits into from Dec 8, 2022

Conversation

ericsnowcurrently
Copy link
Member

@ericsnowcurrently ericsnowcurrently commented Dec 7, 2022 •
edited by bedevere-bot

@ericsnowcurrently ericsnowcurrently requested a review from a team as a code owner Dec 7, 2022
@bedevere-bot bedevere-bot mentioned this pull request Dec 7, 2022
Open
@netlify
Copy link

netlify bot commented Dec 7, 2022 •
edited

✅ Deploy Preview for python-cpython-preview canceled.

Name Link
🔨 Latest commit b8befdc
🔍 Latest deploy log https://app.netlify.com/sites/python-cpython-preview/deploys/63925f7c5c9e170008558b26

@ericsnowcurrently ericsnowcurrently removed the request for review from a team Dec 7, 2022
@ericsnowcurrently ericsnowcurrently merged commit cda9f02 into python:main Dec 8, 2022
18 checks passed
@ericsnowcurrently ericsnowcurrently deleted the consolidate-os-globals branch Dec 8, 2022
@vstinner
Copy link
Member

vstinner commented Dec 9, 2022

This change introduced a reference leak. Example with test_posixpath:

$ ./python -m test test_posixpath -R 3:3 -m test_ismount_directory_not_readable
(...)
test_posixpath leaked [9, 9, 9] references, sum=27
(...)

@vstinner
Copy link
Member

vstinner commented Dec 9, 2022

On PPC64LE Fedora Stable Refleaks 3.x, test_os and test_posixpath started to leak memory: https://buildbot.python.org/all/#builders/280/builds/548

@ericsnowcurrently
Copy link
Member Author

ericsnowcurrently commented Dec 9, 2022

I'll get that fixed.

@ericsnowcurrently ericsnowcurrently mentioned this pull request Dec 9, 2022
Merged
ericsnowcurrently added a commit that referenced this pull request Dec 9, 2022
@ericsnowcurrently
gh-81057: Fix a Reference Leak in the posix Module (gh-100140)
7a0f3c1 
The leak was introduced in gh-100082.

#81057
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ericsnowcurrently @vstinner @bedevere-bot