Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-95174: Handle missing dup() and constants in WASI #95229

Merged
merged 1 commit into from Jul 26, 2022
Merged

gh-95174: Handle missing dup() and constants in WASI #95229

merged 1 commit into from Jul 26, 2022

Conversation

tiran
Copy link
Member

@tiran tiran commented Jul 25, 2022 •
edited by bedevere-bot

  • check for dup() libc function
  • handle missing F_DUPFD in dup2() replacement function
  • add workaround for WASI libc bug in MSG_TRUNC
  • ESHUTDOWN is missing, use EPIPE instead
  • POLLPRI is missing, define as 0 (no-op)

@tiran tiran requested a review from a team as a code owner Jul 25, 2022
This was referenced Jul 25, 2022
Merged
Merged
@tiran tiran requested a review from brettcannon Jul 25, 2022
@tiran
pythongh-95174: Handle missing dup() and constants in WASI
879f63e 
- check for ``dup()`` libc function
- handle missing ``F_DUPFD`` in ``dup2()`` replacement function
- add workaround for WASI libc bug in MSG_TRUNC
- ESHUTDOWN is missing, use EPIPE instead
- POLLPRI is missing, define as 0 (no-op)
@tiran tiran force-pushed the gh-95174-dup-constants branch from c950dbc to 879f63e Compare Jul 25, 2022
@tiran tiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 25, 2022
@bedevere-bot
Copy link

bedevere-bot commented Jul 25, 2022

🤖 New build scheduled with the buildbot fleet by @tiran for commit 879f63e 🤖

If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 25, 2022
@tiran tiran merged commit 0d35a59 into python:main Jul 26, 2022
82 of 84 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Jul 26, 2022

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Jul 26, 2022

Sorry, @tiran, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 0d35a59ce3242b7326890a8c8cc41b321192ec9a 3.11

@tiran tiran deleted the gh-95174-dup-constants branch Jul 26, 2022
@bedevere-bot
Copy link

bedevere-bot commented Jul 26, 2022

GH-95272 is a backport of this pull request to the 3.11 branch.

tiran added a commit to tiran/cpython that referenced this pull request Jul 31, 2022
@tiran
[3.11] pythongh-95174: Handle missing dup() and constants in WASI (py…
dfdb0d3 
…thonGH-95229)

- check for ``dup()`` libc function
- handle missing ``F_DUPFD`` in ``dup2()`` replacement function
- add workaround for WASI libc bug in MSG_TRUNC
- ESHUTDOWN is missing, use EPIPE instead
- POLLPRI is missing, define as 0 (no-op).
(cherry picked from commit 0d35a59)

Co-authored-by: Christian Heimes <christian@python.org>
pablogsal pushed a commit that referenced this pull request Jul 31, 2022
@tiran
[3.11] gh-95174: Handle missing dup() and constants in WASI (GH-95229) (
db13c0c 
GH-95272)

Co-authored-by: Christian Heimes <christian@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@python/windows-team windows-team

@brettcannon brettcannon

Assignees

@tiran tiran

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tiran @bedevere-bot @miss-islington